Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349172 - flag-o-matic.eclass: filter-mfpmath doesn't filter "both" and "387+sse"
Summary: flag-o-matic.eclass: filter-mfpmath doesn't filter "both" and "387+sse"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL: http://archives.gentoo.org/gentoo-dev...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 10:03 UTC by Kacper Kowalik (Xarthisius) (RETIRED)
Modified: 2013-09-05 05:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
cover "both" and "foo+bar" in filter-mfpmath (flag-o-matic.diff,425 bytes, patch)
2010-12-20 10:04 UTC, Kacper Kowalik (Xarthisius) (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-12-20 10:03:23 UTC 
as per man gcc:
-mfpmath=both == 387+sse == 387,sse

currently filter-mfpmath only deals with ',' case
Comment 1 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2010-12-20 10:04:02 UTC 
Created attachment 257611 [details, diff]
cover "both" and "foo+bar" in filter-mfpmath
Comment 2 SpanKY gentoo-dev 2010-12-20 18:00:48 UTC 
simpler to use ${foo//[,+]/ }

although i wonder if we've just out grown this function and shouldnt punt it
Comment 3 Ryan Hill (RETIRED) gentoo-dev 2011-07-20 05:44:20 UTC 
these are the current users:

$ greptree filter-mfpmath
/usr/portage/eclass/gnat.eclass: 261   :		filter-mfpmath sse 387
/usr/portage/eclass/flag-o-matic.eclass: 286   :# @FUNCTION: filter-mfpmath
/usr/portage/eclass/flag-o-matic.eclass: 290   :# has -mfpmath=sse,386, running `filter-mfpmath sse` will leave the user with
/usr/portage/eclass/flag-o-matic.eclass: 292   :filter-mfpmath() {
/usr/portage/dev-db/firebird/firebird-2.1.3.18185.0.ebuild: 133:	filter-mfpmath sse
/usr/portage/dev-db/firebird/firebird-2.5.0.26074.0-r1.ebuild:  89     :	filter-mfpmath sse
/usr/portage/dev-db/firebird/firebird-2.0.3.12981.0-r6.ebuild: 125     :	filter-mfpmath sse
/usr/portage/sci-libs/gsl/gsl-1.14-r1.ebuild:  38      :		&& filter-mfpmath sse
/usr/portage/sci-libs/gsl/gsl-1.15.ebuild:  46 :		&& filter-mfpmath sse
/usr/portage/sci-libs/fftw/fftw-2.1.5-r5.ebuild:  26   :	filter-mfpmath "sse"
/usr/portage/sci-libs/fftw/fftw-2.1.5-r8.ebuild:  28   :	filter-mfpmath "sse"
/usr/portage/net-analyzer/rrdtool/rrdtool-1.2.30.ebuild:  45   :	filter-mfpmath sse
/usr/portage/net-analyzer/rrdtool/rrdtool-1.0.50.ebuild:  38   :	filter-mfpmath sse
/usr/portage/net-analyzer/rrdtool/rrdtool-1.2.29.ebuild:  45   :	filter-mfpmath sse
/usr/portage/dev-lang/ocaml/ocaml-3.11.2.ebuild:  56   :	filter-mfpmath sse
/usr/portage/dev-lang/ocaml/ocaml-3.12.1.ebuild:  56   :	filter-mfpmath sse