Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 349100 - [PATCH]: desktop-integration use flag for x11-misc/pcmanfm-0.5.2
Summary: [PATCH]: desktop-integration use flag for x11-misc/pcmanfm-0.5.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Markos Chandras (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-19 18:32 UTC by Samuel Bauer
Modified: 2010-12-28 13:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Version of pcmanfm ebuild allowing to disable desktop-integration (pcmanfm-0.5.2.ebuild,1.70 KB, text/plain)
2010-12-19 18:35 UTC, Samuel Bauer
Details
patch for pcmanfm-0.5.2, allow to remove desktop integration (pcmanfm-0.5.2.ebuild.patch,732 bytes, text/plain)
2010-12-20 16:58 UTC, Samuel Bauer
Details
Set metadata for the desktop-integration flag (metadata.xml.patch,443 bytes, text/plain)
2010-12-20 17:29 UTC, Samuel Bauer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2010-12-19 18:32:25 UTC
When you download pcmanfm source and try to compile, you can disable the desktop-integration.

For now this is not possible within portage

I've fixed the ebuild.

Reproducible: Always

Steps to Reproduce:
Comment 1 Samuel Bauer 2010-12-19 18:35:08 UTC
Created attachment 257563 [details]
Version of pcmanfm ebuild allowing to disable desktop-integration
Comment 2 Mike Gilbert gentoo-dev 2010-12-19 20:27:49 UTC
When submitting a change to an existing ebuild, please provide it in patch form so the maintainer can see what you have changed at a glance.
Comment 3 Samuel Bauer 2010-12-20 16:58:02 UTC
Created attachment 257627 [details]
patch for pcmanfm-0.5.2, allow to remove desktop integration

Sorry, I didn't know that one should submit a patch when submitting an improvement for an ebuild.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2010-12-20 17:09:57 UTC
Please do not assign the bugs on yourself. Let bug-wranglers do their job :)

Thanks for the patch. I will try to merge it as soon as possible
Comment 5 Samuel Bauer 2010-12-20 17:19:22 UTC
(In reply to comment #4)
> Please do not assign the bugs on yourself. Let bug-wranglers do their job :)
> 
> Thanks for the patch. I will try to merge it as soon as possible
> 

I was just thinking it could be helpful to add the maintainer of the package to the CC list.
Sorry, won't do it again

Comment 6 Samuel Bauer 2010-12-20 17:29:42 UTC
Created attachment 257629 [details]
Set metadata for the desktop-integration flag

very useful when using euses even if the flag name is quite explicit
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2010-12-22 12:11:48 UTC
+  22 Dec 2010; Markos Chandras <hwoarang@gentoo.org> pcmanfm-0.5.2.ebuild,
+  metadata.xml:
+  Introduce desktop-integration use flag. Thanks to Samuel BAUER
+  <samuel.bauer@yahoo.fr>. Bug #349100
+

However, 0.5.2 is way too old. I would strongly recommend to move to the 0.9.X series
Comment 8 Samuel Bauer 2010-12-22 13:44:11 UTC
(In reply to comment #7)
> +  22 Dec 2010; Markos Chandras <hwoarang@gentoo.org> pcmanfm-0.5.2.ebuild,
> +  metadata.xml:
> +  Introduce desktop-integration use flag. Thanks to Samuel BAUER
> +  <samuel.bauer@yahoo.fr>. Bug #349100
> +
> 
> However, 0.5.2 is way too old. I would strongly recommend to move to the 0.9.X
> series
> 

Lot of people don't want to move to 0.9.X series. If 0.5.2 is still in the portage tree mean it's maybe not way too old:

As the main develloper said:
There will be 1.0, but before it become stable enough for production use, let's call it 0.9. See: http://forum.lxde.org/viewtopic.php?f=0&t=1371&sid=4e5c2f6c504269beb7b32f2f48082fb1

A dependency to gvfs(=>gconf), which many users don't want to have, as it break the lightweight philosophy from lxde. Even the main developper of the application is not satisfied by this. See: http://wiki.lxde.org/en/PCManFM_Roadmap

The treeview as disappeared from the 0.9.X series. When this feature will be present, I think that the program will move to 1.0.X series.
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2010-12-28 13:50:22 UTC
Fixed