Bug 348699 – games.eclass: move user and group creation to separate function

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Ulrich Müller 2010-12-14 11:05:20 UTC]

Creation of the games user and group is inlined in pkg_setup, therefore it's not possible to call it separately, without calling check_license and tc-export at the same time.

[Comment 1 Ulrich Müller 2010-12-14 11:07:56 UTC]

Created attachment 257123 [details, diff]
proposed patch

Not sure if "games_create_user" is a good name, since it also creates a group.

[Comment 2 Mr. Bones. (RETIRED) 2010-12-14 16:26:41 UTC]

What problem are you really trying to solve?

[Comment 3 Ulrich Müller 2010-12-14 21:15:30 UTC]

(In reply to comment #2)
> What problem are you really trying to solve?

We have some games in the app-emacs category that could profit from shared score files. Also app-editors/emacs:23 itself installs two such score files, and its build system tries to change owner and group to "games". Which fails if there is no games user on the user's system.

OTOH, this is all GPLed stuff, so there really is no need for calling check_license in these ebuilds.

[Comment 4 Mr. Bones. (RETIRED) 2010-12-14 21:22:43 UTC]

check_license is only called if GAMES_CHECK_LICENSE is set to yes.

[Comment 5 Ulrich Müller 2010-12-14 21:34:28 UTC]

Closing as INVALID followind our conversation in irc.