Got a update for media-sound/teamspeak2-client-bin - no update of the programme itself, but of the ebuild (2.0.32.60 -> 2.0.32.60-r1). The changes are: - Added support for teamspeak://server style links for kde (IUSE="kde"). - As requested moved installation dir to /opt instead of /usr/share (like it is for teamspeak2-server-bin too) - Added MY_P and some sed magic to set it, which should make maintaining the ebuild easier. - Small fixes after reading the "common ebuild writing mistakes" document Reproducible: Always Steps to Reproduce:
Created attachment 21571 [details] the new ebuild. see above.
Nice work on creating a KDE protocol; however, there's a number of strange things going on in this ebuild. Why are you using "mkdir -p ${D}/blah" when there's a perfectly good "dodir /blah" function to use? Your editing of the startscript is very ugly. Why not wait until after the script has been dobinned, then you can do all of that on one dosed line. If you don't want to wait, just add -i to the sed argument and it'll do what you're doing for you. And I believe the preferred way to do a file like the teamspeak.protocol file is to include it with the ebuild and doins it from ${FILESDIR}. Also, your einfo referring to the protocol file is not necessary and is actually broken. The insinto and the dosym near the end of the install are not necessary. dobin is not affected by insinto and there's no reason to do it some other way than by a dobin. The startscript does not need to be copied into /opt/teamspeak2-client, AFAIK.
Oh, and my gosh, you don't think including src_unpack() { unpack ${A} } in the ebuild is kind of redundant? 'man 5 ebuild' can be a very useful resource.
Created attachment 21669 [details] teamspeak.protocol, to go into the files directory As requested I have detached the teamspeak.protocol file. Didnt know this was possible, gotta agree it makes the ebuild much cleaner =).
Created attachment 21670 [details] revised ebuild. Ok, cleaned up this ebuild quite alot with your help :). Removed the src_unpack() part (since it is done this way by default, now using dodir instead of mkdir -p, changed sed to use the in-place option, avoiding the clumsy handling with the temp files, out-sourced the teamspeak.protocol (now a external file), cleaned up the redundant insinto and removed the pointless dosym.
Oh and btw: If anybody knows how I would make links like "teamspeak://voice.teamspeak.org" work in other browsers/desktop-enviroments (thinking of gnome and mozilla here especially), please tell me how to do it, Id love to support these links with many (all) browsers that linux offers.
Created attachment 21707 [details] ebuild-r2 with revised install Sorry, Peter, don't mean to encroach upon your territorry, but I expanded upon your excellent work to create this ebuild. - I revised $S to better reflect the actual source directory we're working with. - I variableized the install directory. - I cleaned the sed command. - I modified the kde protocol installation. If the user USE="KDE" then kdelibs will definately be installed, as will `kde-config`. Whereas $KDEBASE may or may not be set in the environment. - The readme and manual are installed in true Gentoo fashion and a symlink is made so that Help -> Read Manual still works. - Everything that shouldn't be executable has it's x bits removed. - Finally, I revised the postinstall einfo. If you have any questions or concerns, feel free to ask or state them. To the devs: Also, with the submission of this ebuild, I officially and whole-heartedly object to the naming of this package. Specifically, I object to the addition of -bin to the end of the name. The -bin convention should be reserved for packages that have both a source and binary version available. For example mozilla-firebird and mozilla-firebird-bin, or openoffice and openoffice-bin. We don't name quake3 as quake3-bin, or rar as rar-bin, or acroread as acroread-bin dispite the fact that they are binary packages. Why should this package be any different? There is no source distribution available. Thank you for listening.
Created attachment 21962 [details] bad ebuild, didnt read before submitted. Oh well, after some more poking around, I thought it would be cool to put the icon that comes with teamspeak into the /usr/share/pixmaps directory, so that users can use it for Desktop icons etc. Since the xpm didnt work for me (in kde at least), I have it converted to pgn in the ebuild. Everything else unchanged.
Oh, didn't see your revised ebuild there, stupid me. Maybe you want to incoperate the icon into your ebuild Keith Constable ? These are the crude lines I chose to type, I bet it can be done nicer =) #Install the teamspeak icon. dodir /usr/share/pixmaps convert ${S}/setup.data/image/icon.xpm ${S}/setup.data/image/teamspeak.png cp ${S}/setup.data/image/teamspeak.png ${D}/usr/share/pixmaps/ Im not sure if the convert from imagemagick is the right thing to use, nor do I know of /usr/share/pixmap is the definite place for icons, but it works like this here, so it cant be that bad =). Oh naturally you need a dependency for imagemagick if you use convert. And as a side note: I always thought the -bin on teamspeak2-client + server wasn't very coherent :o).
OK, I added the lines myself then :) Icon support, here we go
Created attachment 25720 [details] keiths improved ebuild, improved with icon support Well, the improved ebuild that copies the teamspeak icon and converts it to something readable. I cant obsolete Keiths ebuild though, propably because I did not submit it :).
Created attachment 25721 [details] keiths improved ebuild, with icon support + bugfix Ok, same description, I just squashed a bad quote that was flying around in that ebuild. It should obsolete Keiths ebuild, but thats disabled (for me).
Created attachment 25722 [details] bugfix, keiths improved ebuild, with icon support doh, I realy should test the ebuilds before submitting them here :)
in portage...
