Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 348460 - gnome-terminal title is not restored correctly after running emerge
Summary: gnome-terminal title is not restored correctly after running emerge
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High normal
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS, REGRESSION
Depends on:
Blocks: 349307
  Show dependency tree
 
Reported: 2010-12-12 00:31 UTC by redneb
Modified: 2010-12-21 18:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
screenshot (screenshot.png,52.28 KB, image/png)
2010-12-12 00:32 UTC, redneb
Details

Note You need to log in before you can comment on or make changes to this bug.
Description redneb 2010-12-12 00:31:04 UTC
When I run emerge inside a gnu screen session it fails to "correctly" restore the title of the gnome-terminal on exit. By correctly I mean that the actual title is restored but the text inside the button in the window list panel is not (see attached screenshot). This only happens when emerge is ran from gnu screen. Also, this bug does not exist in sys-apps/portage-2.1.8.3 but does exist in sys-apps/portage-2.1.9.24.

Reproducible: Always

Steps to Reproduce:
Comment 1 redneb 2010-12-12 00:32:21 UTC
Created attachment 256932 [details]
screenshot
Comment 2 Zac Medico gentoo-dev 2010-12-12 01:25:43 UTC
The only change that I see for that code between 2.1.8 and 2.1.9 is this commit, and it doesn't seem like it would cause any problems:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=3beb2d432d4fe288b3b1fafefcb702bd524ed4cd
Comment 3 redneb 2010-12-12 01:37:58 UTC
I am trying to do a git bisect to find the commit that causes this problem but I have no idea how to install portage directly from sources. Is there an easy way? Or do I have to use mkrelease.sh and the ebuild?
Comment 4 Zac Medico gentoo-dev 2010-12-12 01:40:10 UTC
You can run portage directly from a checkout if you modify the PATH and PYTHONPATH variables as describe here:

  http://www.gentoo.org/proj/en/portage/doc/testing.xml#doc_chap3
Comment 5 redneb 2010-12-12 12:17:17 UTC
Your guess was correct:
  3beb2d432d4fe288b3b1fafefcb702bd524ed4cd is the first bad commit

In particular the problem is caused by the line:
  prompt_command = os.environ.get('PROMPT_COMMAND', '')

When I change it to:
  prompt_command = os.environ.get('PROMPT_COMMAND', None)
or revert it to the old version with os.getenv, I get the old behavior.
Comment 7 Zac Medico gentoo-dev 2010-12-13 07:16:16 UTC
This is fixed in 2.2.0_alpha8, but I'll leave this bug open until it's in an unmasked release.
Comment 8 Zac Medico gentoo-dev 2010-12-21 18:57:38 UTC
This is fixed in 2.1.9.26.