Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 348402 - www-client/chromium doesn't use store passwords with gnome-keyring with USE="gnome-keyring"
Summary: www-client/chromium doesn't use store passwords with gnome-keyring with USE="...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Chromium Project
URL:
Whiteboard: ht-wanted
Keywords:
: 352821 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-12-11 04:27 UTC by Matt Turner
Modified: 2011-01-27 07:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2010-12-11 04:27:38 UTC
Even with USE="gnome-keyring" chromium does not store my saved passwords in gnome-keyring.

If I run `chromium` and save a password, it appears only in Chromium's Personal Stuff -> Show Saved Passwords dialog, but not in Seahorse.

If I run `chromium --password-store=gnome` or even `chromium --password-store=detect` and save a password, it saves the password in gnome-keyring so that it's visible from Seahorse.

I might just not know enough about Chromium's password handling, but it seems to me that `chromium --password-store=detect` should be default.
Comment 1 Mike Gilbert gentoo-dev 2010-12-11 04:52:34 UTC

*** This bug has been marked as a duplicate of bug 335758 ***
Comment 2 Matt Turner gentoo-dev 2010-12-11 05:06:18 UTC
I'm going to reopen, as the the other bug looks like it's turned into "--password-store=detect" doesn't work with kwallet _sometimes_.
Comment 3 Fatih 2010-12-11 08:56:14 UTC
> I might just not know enough about Chromium's password handling, but it seems
> to me that `chromium --password-store=detect` should be default.
> 

Your suggestion has already been made by Mike at #335758 . That is the intended future behaviour anyway... See http://code.google.com/p/chromium/issues/detail?id=12351#c33 and

From http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/814d112acb8944c2?pli=1 :
<quote>
I've recently committed r50475 which adds a new flag, 
--password-store, that lets you request GNOME Keyring or (KDE) KWallet 
instead of the built-in unencrypted password store. 
There are three possible values: 
--password-store=gnome 
--password-store=kwallet 
--password-store=detect (this will eventually be the default) 
</quote>
Comment 4 Matt Turner gentoo-dev 2010-12-12 01:41:34 UTC
(In reply to comment #3)
> Your suggestion has already been made by Mike at #335758 . That is the intended
> future behaviour anyway...

That's fine and well, but can't we (Gentoo) should go ahead and do this? If USE="gnome-keyring" then set --password-store=gnome/detect as default.
Comment 5 Mike Gilbert gentoo-dev 2010-12-12 02:01:41 UTC
For what it is worth, I have been using KDE/kwallet for a few weeks with chromium-9999 builds, and have yet to notice the random failures mentioned in the other bug.

Is that still a problem, or has it magically fixed itself?

Unrelated: I think I like KDE better than GNOME, so I am sticking with this config for now.
Comment 6 Fatih 2010-12-12 08:51:13 UTC
(In reply to comment #5)
> For what it is worth, I have been using KDE/kwallet for a few weeks with
> chromium-9999 builds, and have yet to notice the random failures mentioned in
> the other bug.
> 
> Is that still a problem, or has it magically fixed itself?
> 

Was still a problem when I decided to give a gnome-keyring a try --which is working fine though I don't like gnome. I did not try 9999. Upstream asked me to reproduce the issue with branded chrome. But I failed to do so on a system with USE="-cups".  
Comment 7 Fatih 2010-12-12 09:01:50 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Your suggestion has already been made by Mike at #335758 . That is the intended
> > future behaviour anyway...
> 
> That's fine and well, but can't we (Gentoo) should go ahead and do this? If
> USE="gnome-keyring" then set --password-store=gnome/detect as default.
> 

(In reply to comment #4)
> (In reply to comment #3)
> > Your suggestion has already been made by Mike at #335758 . That is the intended
> > future behaviour anyway...
> 
> That's fine and well, but can't we (Gentoo) should go ahead and do this? If
> USE="gnome-keyring" then set --password-store=gnome/detect as default.
> 

In a post to other bug I had voted for it [detect]. Enabling it by checking against gnome-keyring would not be fair to kde users. Detect switch with only kwallet installed was not always working for me. I think they are waiting for enough number of 'works for me' before doing it. 
Comment 8 Matt Turner gentoo-dev 2010-12-12 17:09:56 UTC
(In reply to comment #7)
> In a post to other bug I had voted for it [detect]. Enabling it by checking
> against gnome-keyring would not be fair to kde users. Detect switch with only
> kwallet installed was not always working for me. I think they are waiting for
> enough number of 'works for me' before doing it. 

Look, I'm sorry kwallet+chromium doesn't work for you, but that's not a reason to prevent it from working for everyone else. If it's not fair to KDE users, it's because there's a bug between kwallet and chromium, and not that password storage does work with gnome-keyring.

This is not an upstream bug. I'm suggesting adding --password-store=detect/gnome for USE="gnome-keyring" to chromium's desktop file. It won't affect you, so please...
Comment 9 Mike Gilbert gentoo-dev 2010-12-12 17:22:43 UTC
Okay, here is my take:
- Fatih is the currently only one who is able to reproduce the kwallet problem.
- Upstream bug is stalled.

Perhaps we could enable --password-store=detect in the dev channel releases to
get additional feedback?
Comment 10 Fatih 2010-12-12 20:41:21 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > In a post to other bug I had voted for it [detect]. Enabling it by checking
> > against gnome-keyring would not be fair to kde users. Detect switch with only
> > kwallet installed was not always working for me. I think they are waiting for
> > enough number of 'works for me' before doing it. 
> 
> Look, I'm sorry kwallet+chromium doesn't work for you, but that's not a reason
> to prevent it from working for everyone else. If it's not fair to KDE users,
> it's because there's a bug between kwallet and chromium, and not that password
> storage does work with gnome-keyring.
> 
> This is not an upstream bug. I'm suggesting adding
> --password-store=detect/gnome for USE="gnome-keyring" to chromium's desktop
> file. It won't affect you, so please...
> 

I am not against enabling the switch. I am for it. What I meant was enabling it by only checking against gnome-keyring use flag would not benefit users without gnome-keyring use flag. So perhaps it should be --password-store=detect unconditionally and --password-store=gnome if gnome-keyring use flag is present.
Comment 11 Fatih 2010-12-12 20:45:27 UTC
(In reply to comment #9)
> Okay, here is my take:
> - Fatih is the currently only one who is able to reproduce the kwallet problem.
> - Upstream bug is stalled.
> 
Unfortunately and oddly, yes. 

> Perhaps we could enable --password-store=detect in the dev channel releases to
> get additional feedback?
> 
Why not in the beta channel as well? Most people use beta I believe.
Comment 12 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-12-14 16:13:40 UTC
I'd rather avoid setting different defaults than the upstream. Feel free to file an upstream bug (search for duplicates first), and post the link here.
Comment 13 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-01-05 10:08:00 UTC
Is it still a problem with chromium-10.x? According to http://code.google.com/p/chromium/wiki/LinuxPasswordStorage the 10 series should have new defaults.
Comment 14 Mike Gilbert gentoo-dev 2011-01-06 00:38:06 UTC
(In reply to comment #13)
> Is it still a problem with chromium-10.x? According to
> http://code.google.com/p/chromium/wiki/LinuxPasswordStorage the 10 series
> should have new defaults.
> 

It doesn't work automatically for me on 10.0.612.1-r1. I am running KDE 4.4 with USE="-gnome-keyring".

When I run chromium --password-store=detect, it finds KWallet and uses that; without --password-store, it still uses the built-in password store.
Comment 15 Julien Sanchez archtester 2011-01-06 07:57:46 UTC
Just my experience with gnome:
I'm using chromium-9999 (10.0.628.0 (70411)) and gnome-keyring USE

Until now chromium (launched without --password-store switch) seems to use builtin password store with my profile (used for a long time).

With an empty profile, it automatically uses gnome password store.

When I explicitely launched with chromium --password-store=gnome with my old profile, passwords from built-in store has appeared in seahorse (?? don't know why, automatic migration?). And now if I relaunch chromium without --password-store switch, it automatically uses gnome keyring).
Comment 16 Tassilo Horn 2011-01-24 10:51:08 UTC
> I'm using chromium-9999 (10.0.628.0 (70411)) and gnome-keyring USE
> 
> Until now chromium (launched without --password-store switch) seems to use
> builtin password store with my profile (used for a long time).
> 
> With an empty profile, it automatically uses gnome password store.

I use www-client/chromium-9.0.597.67 with +gnome-keyring, and I've deleted my whole profile (~/.config/chromium), but the passwords are still not stored in the GNOME keyring.  I don't issue any command line option.  Is the default of saving in a auto-detected keyring only in later versions of chromium?
Comment 17 Julien Sanchez archtester 2011-01-24 11:09:23 UTC
> I use www-client/chromium-9.0.597.67 with +gnome-keyring, and I've deleted my
> whole profile (~/.config/chromium), but the passwords are still not stored in
> the GNOME keyring.  I don't issue any command line option.  Is the default of
> saving in a auto-detected keyring only in later versions of chromium?
> 
Yes, Gnome keyring is used by auto-detection and by default only from chromium 10.


"Support for using GNOME Keyring and KWallet was added in version 6, but using these (when available) was not made the default mode until version 10."
http://code.google.com/p/chromium/wiki/LinuxPasswordStorage
Comment 18 Tassilo Horn 2011-01-24 12:54:46 UTC
(In reply to comment #17)

> Yes, Gnome keyring is used by auto-detection and by default only from chromium
> 10.

Thank you.  Then I'll try version 10 as soon as I find some time.
Comment 19 Tassilo Horn 2011-01-25 07:31:11 UTC
Ok, now I have chromium-10.0.642.2-r1 with USE=gnome-keyring installed and started over with a fresh profile (deleted ~/.config/chromium/ and ~/.cache/chromium/).

How can I validate that it really uses the gnome keyring?  I don't have gnome installed (I use XFCE), so I don't have a GUI for the keyring (AFAIK).  And in the chromium preferences, the passwords are listed as usual...

(The tip "check if you are asked for your keyring password when saving a new password in chromium" doesn't work because of a hen-and-egg problem.  I need to unlock the keyring to make NetworkManager login to the network before I can start working in chromium...)
Comment 20 Julien Sanchez archtester 2011-01-25 10:21:35 UTC
You could try to install seahorse to check stored passwords in gnome keyring.
Comment 21 Tassilo Horn 2011-01-25 10:56:12 UTC
(In reply to comment #20)
> You could try to install seahorse to check stored passwords in gnome keyring.

Ah, that's the name of the GUI.  I searched for "keyring" using eix -S, but the description of seahorse doesn't contain that.

Anyway, now I could check that the passwords are indeed in the keyring (application: chrome in the details tab).  Great!
Comment 22 Julien Sanchez archtester 2011-01-25 11:02:26 UTC
This bug could perhaps be closed now since behavior will be correct in chromium 10 and later.
Comment 23 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-01-25 11:06:35 UTC
(In reply to comment #22)
> This bug could perhaps be closed now since behavior will be correct in chromium
> 10 and later.

That's very likely. Matt, could you confirm it's fixed for you with >=chromium-10?
Comment 24 Matt Turner gentoo-dev 2011-01-25 15:07:33 UTC
Yes, indeed. It is fixed in Chromium-10. Marking fixed.
Comment 25 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2011-01-27 07:19:32 UTC
*** Bug 352821 has been marked as a duplicate of this bug. ***