Bug 34800 – Mirrorselect overwrites all commented out GENTOO_MIRROR lines

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Donovan Long 2003-11-30 22:13:27 UTC]

Typically I always "back up" my GENTOO_MIRROR configuration in /etc/make.conf by 
copying that line, pasting it back in and commenting it out.  Sometimes I do 
this to merge new servers to the existing servers configuration.

Tonight I noticed I didn't have iblio in my list, and Portage wasn't able to get 
some packages, so I ran mirrorselect to add iblio it to my make.conf file with 
the intention of putting it at the end of my current (commented and not 
commented out versions) server list.

Instead I have this:
# Good mirror layout: Seren, Polymtl, ubishops, ualberta, sandia, purdue, iu, 
ibilio, gatech
GENTOO_MIRRORS="ftp://ibiblio.org/pub/Linux/distributions/gentoo/ http://www.
gtlib.cc.gatech.edu/pub/gentoo"
GENTOO_MIRRORS="ftp://ibiblio.org/pub/Linux/distributions/gentoo/ http://www.
gtlib.cc.gatech.edu/pub/gentoo"
GENTOO_MIRRORS="ftp://ibiblio.org/pub/Linux/distributions/gentoo/ http://www.
gtlib.cc.gatech.edu/pub/gentoo"
GENTOO_MIRRORS="ftp://ibiblio.org/pub/Linux/distributions/gentoo/ http://www.
gtlib.cc.gatech.edu/pub/gentoo"
GENTOO_MIRRORS="ftp://ibiblio.org/pub/Linux/distributions/gentoo/ http://www.
gtlib.cc.gatech.edu/pub/gentoo"

mirrorselect found any replaced any and all lines containing GENTOO_MIRROR, even 
my commented out (using # as the first char) ones, which are now lost.  Rats!!

:)

Reproducible: Always
Steps to Reproduce:
1. Run mirrorselect
Actual Results:  
Mirroselect overwrote my commented out GENTOO_MIRROR lines, a new behavior it 
hasn't done before.

Expected Results:  
Ideally it would update or add the old/new GENTOO_MIRROR directive and leave the 
commented ones alone, like it has always done in the past.

[Comment 1 Donovan Long 2003-11-30 22:15:26 UTC]

I'm using app-portage/mirrorselect-0.82-r2, BTW.

[Comment 2 Fred Van Andel (RETIRED) 2003-12-01 10:37:51 UTC]

This bug has been assigned to me (I am not quite sure why). 

I will take a look at it tonight when I get home.

[Comment 3 Fred Van Andel (RETIRED) 2003-12-01 14:40:51 UTC]

Created attachment 21561 [details]
Test version of mirrorselect

Attached to this message is a fixed version of mirrorselect.

Can you please test it and tell me if it works on your system.	If it works I
will create a new ebuild for it.

[Comment 4 Donovan Long 2003-12-03 11:40:33 UTC]

Tested and works as desired, thank you!

[Comment 5 John Mylchreest (RETIRED) 2004-08-22 05:34:30 UTC]

old bug