An RC of Clementine 0.6 was released. Attached is an ebuild which builds it. Reproducible: Always
Created attachment 256494 [details, diff] patch: 0.5.3 -> 0.6_rc1
Thanks, in multimedia overlay.
If you can include this patch it may be possible to make liblastfm optional and thus we can get rid of ruby dependency. :) http://code.google.com/p/clementine-player/issues/detail?id=49
liblastfm needs ruby only for building, it is not rdepend. Do 'emerge --depclean --with-bdeps=n -a' after installing clementine. I like the idea of making liblastfm optional depend, but the patch seems completely untested and unsupported. If it works fine for you, comment upstream bug.
Final version out.
Created attachment 256949 [details] ebuild
Created attachment 257104 [details, diff] patch: 0.5.3 -> 0.6 Patch for final version 0.6. Changes are only: Support USE=ayatana / gnome-soundmenu, and adding qt-dbus/qt-webkit to dependencies (taken from CMakeLists).
Dennis, read other attachments before adding new, all changes in my ebuild are necessary. P.S. Do not add x11-libs/qt-dbus:4. x11-libs/qt-gui:4[dbus] depends on it and already is in ebuild. clementine does not need qt-webkit and qt-phonon, it is not linked to them and builds fine without them. Ayatana is not global USE, clementine uses 'soundmenu' cmake option.
(In reply to comment #8) > Dennis, read other attachments before adding new, all changes in my ebuild are > necessary. Then please add a patch, so that it is clearly visible what these are. > clementine does not need qt-webkit and qt-phonon, it is > not linked to them and builds fine without them. CMakeLists contains: find_package(Qt4 COMPONENTS Phonon QtWebKit) Did you check that there is no conditional code depending on the presence of WebKit? (The Phonon engine is conditional, and disabled by ENGINE_QT_PHONON_ENABLED.) Please do not forget to check for load-at-runtime situations. > Ayatana is not global USE, clementine uses 'soundmenu' cmake option. Other applications, like Quassel and previously KMail use the ayatana useflag for their libindicate (part of the Ayatana project) related parts. Hence I feel that ayatana is the right name for the flag, especially when thinking about useflag pollution.
Created attachment 257437 [details, diff] ebuild patch 0.5.3 -> 0.6 with optional liblastfm depend Needs additional patch from here: http://code.google.com/p/clementine-player/issues/detail?id=49 I will also upload it to this ticket.
Created attachment 257438 [details, diff] patch pack to make liblastfm optional From here: http://code.google.com/p/clementine-player/issues/detail?id=49#c18
(In reply to comment #10) > Created an attachment (id=257437) [details] > ebuild patch 0.5.3 -> 0.6 with optional liblastfm depend > > Needs additional patch from here: > http://code.google.com/p/clementine-player/issues/detail?id=49 > > I will also upload it to this ticket. > Without the patch from upstream the compilation fails. But with the patch I was able to compile it without liblastfm dependency. I wasn't tested 0.6 thoroughly, I just ran it and imported a couple of thousand mp3s and played some of them.
(In reply to comment #12) > Without the patch from upstream the compilation fails. Do you have details? build.log, emerge--info, etc?
(In reply to comment #13) > (In reply to comment #12) > > Without the patch from upstream the compilation fails. > Do you have details? build.log, emerge--info, etc? > Sure, I forgot to attach before.
Created attachment 257440 [details] build logs and emerge --info build logs and emerge --info from building clementine-0.6 with and without the liblastfm patch
(In reply to comment #15) > build logs and emerge --info from building clementine-0.6 with and without the > liblastfm patch Which version of liblastfm do you have installed? Which ebuild are you exactly using?
(In reply to comment #16) > (In reply to comment #15) > > build logs and emerge --info from building clementine-0.6 with and without the > > liblastfm patch > Which version of liblastfm do you have installed? Which ebuild are you exactly > using? > I don't have any at all :) My goal was to be able to compile clementine without liblastfm (and ruby). If you need some testing I can install them temporary.
(In reply to comment #17) > I don't have any at all :) In this case your complaint about compilation failing is rather moot, ain't it? Having a look at your patch, settingsdialog.ui seems suspicious. You entirely remove all lastfm references... So even in a build with lastfm, there will be no settings about it, is that correct?
(In reply to comment #18) > (In reply to comment #17) > > I don't have any at all :) > In this case your complaint about compilation failing is rather moot, ain't it? > Well, I know why it failed. I didn't complain about it. I just wanted to note that now we can build clementine without it. > Having a look at your patch, settingsdialog.ui seems suspicious. You entirely > remove all lastfm references... So even in a build with lastfm, there will be > no settings about it, is that correct? > Yes, you are right. Maybe we could make that patch optional, wheter we use lastfm USE flag or not. And also note the users about this behaviour in the ebuild. Please note that those patches are from upstream's bugtracker, I haven't changed them in any way.
0.6 in portage
(In reply to comment #20) > 0.6 in portage > At least can I get an explanation why was my modification dropped without any notes?
(In reply to comment #21) > (In reply to comment #20) > > 0.6 in portage > > > > At least can I get an explanation why was my modification dropped without any > notes? > You mean the patch making liblastfm optional? I'd rather wait upstream includes it, and we'll get it with version 0.6.1 or such. Other than that, I'm just a commit monkey for Nikoli, the actual maintainer for clementine :)
(In reply to comment #22) > (In reply to comment #21) > > (In reply to comment #20) > > > 0.6 in portage > > > > > > > At least can I get an explanation why was my modification dropped without any > > notes? > > > > You mean the patch making liblastfm optional? I'd rather wait upstream > includes it, and we'll get it with version 0.6.1 or such. > Other than that, I'm just a commit monkey for Nikoli, the actual maintainer for > clementine :) > Okay, not it's clear to me. Thanks for the clarification.
Balazs, when upstream will fix automagic issue, we can backport changes and add 0.6-r1: http://code.google.com/p/clementine-player/issues/detail?id=1138
0.6-r1 with optional (backported r2436, r2448, r2458) liblastfm is in multimedia overlay. If it works fine for you, please comment here.
(In reply to comment #25) > 0.6-r1 with optional (backported r2436, r2448, r2458) liblastfm is in > multimedia overlay. If it works fine for you, please comment here. > I was able to compile it with and without lastfm USE flag. In both cases works fine for me. I am attaching the build logs from both compilation.
Created attachment 257584 [details] build logs from clementine-0.6-r1 (multimedia-overlay)
(In reply to comment #25) > 0.6-r1 with optional (backported r2436, r2448, r2458) liblastfm is in > multimedia overlay. If it works fine for you, please comment here. > Works for me, on x86, with +lastfm and -lastfm
clementine-0.6-r2 with 'clementine-0.6-optional-dbus-devicekit.patch' is in overlay.
http://code.google.com/p/clementine-player/source/detail?r=2497 Upstream accepted my patch, updated overlay.
