Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 34773 - Correct setting of MY_ARCH in pcmcia-cs-3.2.5 ebuild on archs other than x86 and ppc
Summary: Correct setting of MY_ARCH in pcmcia-cs-3.2.5 ebuild on archs other than x86 ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: Alpha Linux
: High minor (vote)
Assignee: Mobile Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 34771
  Show dependency tree
 
Reported: 2003-11-30 12:53 UTC by Shaun Cloherty
Modified: 2003-12-19 10:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated pcmcia-cs-3.2.5.ebuild to fix alpha and other cleanup (pcmcia-cs-3.2.5.ebuild,4.31 KB, text/plain)
2003-12-02 18:34 UTC, Aron Griffis (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun Cloherty 2003-11-30 12:53:03 UTC
The pcmcia-cs-3.2.5.ebuild checks the value of ARCH, effectively mapping "x86"
to "i386" for the pcmcia-cs build process. When ARCH is not "x86" MY_ARCH gets
set to "ppc", ie.

# check arch for configure
if [ ${ARCH} = "x86" ] ; then
        MY_ARCH="i386"
else
        MY_ARCH="ppc"
fi

This would seem incorrect on architectures other than x86 or ppc. I suggest
preservation of ARCH as follows;

# check arch for configure
if [ ${ARCH} = "x86" ] ; then
        MY_ARCH="i386"
else
        MY_ARCH=${ARCH}
fi



Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Brian Jackson (RETIRED) gentoo-dev 2003-11-30 20:01:50 UTC
Does this actually affect any other arches?
Comment 2 Shaun Cloherty 2003-11-30 20:20:15 UTC
Yes, alpha. See bug #34771.
Comment 3 Aron Griffis (RETIRED) gentoo-dev 2003-12-02 18:34:18 UTC
Created attachment 21616 [details]
updated pcmcia-cs-3.2.5.ebuild to fix alpha and other cleanup

I didn't notice this bug when I was working on bug 34771, so I didn't realize
a change needs to be made to the ebuild to support alpha properly.  Considering

the KEYWORDS present in the ebuilds, I think the proper fix would be to use the

attached updated ebuild (which also does a lot of cleanup but should not
require a rev bump)

I have tested this updated ebuild on x86 and alpha
Comment 4 Shaun Cloherty 2003-12-05 23:55:05 UTC
I've tested the attached ebuild on alpha. No problems.
Comment 5 Peter Johanson (RETIRED) gentoo-dev 2003-12-19 10:20:13 UTC
Okay, just commited these fixes and added ~alpha to the keywords. Alpha guys can feel free to keyword it "alpha" at your leisure. Thanks for the cleanups!