Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 347717 - dev-lang/lua-5.1.4-r6: please remove some unnecessary slashes from the ebuild
Summary: dev-lang/lua-5.1.4-r6: please remove some unnecessary slashes from the ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial
Assignee: Matti Bickel (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-04 13:43 UTC by Martin Walch
Modified: 2011-01-09 17:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch removing slashes and fixing a typo (lua-5.1.4-r6.patch,1.34 KB, patch)
2010-12-04 13:45 UTC, Martin Walch
Details | Diff
does the same thing, but is more careful (lua-5.1.4-r6.patch,1.36 KB, patch)
2010-12-05 13:04 UTC, Martin Walch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Walch 2010-12-04 13:43:23 UTC
The ebuild contains some slashes in paths that are not needed. Particularly, there is a double slash for most systems in the line:

> RPATH="${ROOT}/usr/$(get_libdir)/" \

as ${ROOT} expands in most times to /, yielding a preceding double slash. This is ugly as this double slash spreads throughout the system, because libtool adapts the path for other programs that link against lua (and then not only for the path of the lua library, but also for other libraries in the same directory).

I will attach a patch for the dev-lang/lua-5.1.4-r6 ebuild, removing this and other slashes that I think are not needed. Also a typo in a comment is fixed.

btw: there are some patches in ${FILESDIR}/5.1.3 - can they be deleted?
Comment 1 Martin Walch 2010-12-04 13:45:10 UTC
Created attachment 256311 [details, diff]
patch removing slashes and fixing a typo

typo: Not that -> Note that
Comment 2 Martin Walch 2010-12-05 13:04:33 UTC
Created attachment 256390 [details, diff]
does the same thing, but is more careful
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2010-12-05 21:15:54 UTC
Why not simply use ${ROOT:-/}? That would simplify the patch rather much.
Comment 4 Martin Walch 2010-12-07 14:26:35 UTC
I don't understand what exactly your expression does. However, you are right: it is possible to make things more simple. I guess

RPATH="${ROOT%/}/usr/$(get_libdir)/" \

should do the trick.
Comment 5 Matti Bickel (RETIRED) gentoo-dev 2011-01-09 17:35:25 UTC
I've comitted lua-5.1.4-r7, which should fix this. ${ROOT} wasn't allowed there, anyway.