Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 347661 - x11-terms/guake should not install Python code to /usr/lib64/guake/
Summary: x11-terms/guake should not install Python code to /usr/lib64/guake/
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-03 16:07 UTC by Sebastian Pipping
Modified: 2010-12-06 08:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Pipping gentoo-dev 2010-12-03 16:07:50 UTC
$ equery f guake | fgrep .py
/usr/lib64/guake/common.py
/usr/lib64/guake/dbusiface.py
/usr/lib64/guake/guake.py
/usr/lib64/guake/guake_globals.py
/usr/lib64/guake/prefs.py
/usr/lib64/guake/simplegladeapp.py

Also, please try to convert the ebuild to a multi-ABI version, see <http://www.gentoo.org/proj/en/Python/developersguide.xml> for details.

If that is not possible, please add SUPPORT_PYTHON_ABIS="0".
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2010-12-03 16:12:24 UTC
I'm not following:

- libdir is valid location for python code, it can be byte-compiled there to .pyc/.pyo

- ebuild is depending on Python 2.x, at least 2.6

- ebuild is setting the active python to version 2.x

So:

- no need for such SUPPORT_PYTHON_ABIS="0" variable
- not intrested in supporting multiple ABIs, only intrested in building it for latest 2.x version (soon as user has selected it, and ran python-updater like it has always been done)

if you have real bugs, please do file one
Comment 2 Sebastian Pipping gentoo-dev 2010-12-03 19:53:17 UTC
(In reply to comment #1)
> - libdir is valid location for python code, it can be byte-compiled there to
> .pyc/.pyo

It's not a common location location to install Python code to.
Yes, there are expections, but I don't see why Guake should be one of those.

This is what I mean by "common location":

$ python -c "import sys; print '\n'.join(sys.path)"

/usr/lib64/python26.zip
/usr/lib64/python2.6
/usr/lib64/python2.6/plat-linux2
/usr/lib64/python2.6/lib-tk
/usr/lib64/python2.6/lib-old
/usr/lib64/python2.6/lib-dynload
/usr/lib64/python2.6/site-packages
/usr/lib64/python2.6/site-packages/gst-0.10
/usr/lib64/python2.6/site-packages/gtk-2.0


> - ebuild is depending on Python 2.x, at least 2.6

While you mention that: /usr/bin/guake is calling /usr/bin/python, not /usr/bin/python2.  So it may be run with Python 3.x by mistake.


> - no need for such SUPPORT_PYTHON_ABIS="0" variable

That would be favor to me, when touching it the next time.
I consider that good style, as it reduces time inspecting the ebuilds' nature.


> if you have real bugs, please do file one

I don't find your behavior on this bug very respectful, honestly.
Comment 3 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2010-12-05 15:13:27 UTC
(In reply to comment #0)
> If that is not possible, please add SUPPORT_PYTHON_ABIS="0".

SUPPORT_PYTHON_ABIS="any_non_empty_value" is used to enable support for multiple Python ABIs.
Comment 4 Sebastian Pipping gentoo-dev 2010-12-06 08:22:16 UTC
(In reply to comment #3)
> SUPPORT_PYTHON_ABIS="any_non_empty_value" is used to enable support for
> multiple Python ABIs.

Thanks for pointing that out.  Please document that behavior on
http://www.gentoo.org/proj/en/Python/developersguide.xml