Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 347029 - net-misc/unison-2.27.52-r1 / 2.32.52 hangs up when "contacting server" when Password is needed
Summary: net-misc/unison-2.27.52-r1 / 2.32.52 hangs up when "contacting server" when P...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High normal with 4 votes (vote)
Assignee: Gentoo Team for the ML programming language family
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-28 01:23 UTC by David Turner
Modified: 2016-05-06 10:08 UTC (History)
11 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Source patch correcting the hangup. (unison-2.27.57-arch-1.patch,219 bytes, patch)
2010-11-28 01:25 UTC, David Turner
Details | Diff
Modified Ebuild For Overlay Test (Only change is to apply patch supplied) (unison-2.27.57-r2.ebuild,2.39 KB, text/plain)
2010-11-28 01:27 UTC, David Turner
Details
Original Patch from Arch Linux Bugtracker for Comparison - Note second section seems already applied in source code... (arch_patch,788 bytes, text/plain)
2010-11-28 01:28 UTC, David Turner
Details
Local ebuild for building a working unison 2.32.52 (unison-2.32.52-r1.ebuild,2.49 KB, text/plain)
2011-03-11 16:19 UTC, Mario Chisari
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Turner 2010-11-28 01:23:07 UTC
Unison hangs with no progress from "Contacting Server..." dialog when a password is required to be entered.

This is caused by the upgrade to OpenSSH 5.6 and is a known issue i.e. :
https://bugs.archlinux.org/task/20877

It may be the root cause of bug #335107 which was closed on a workaround..

I have modified the Arch patch and this corrects the issue. Will attach.

Reproducible: Always

Steps to Reproduce:
1. Ensure x11-ssh-askpass _is_ installed
2. Start Unison sync with SSH root requiring password to be entered
2. Hit "Go"
3. Dialog with "Contacting Server..." will be shown.. but will not progress
Comment 1 David Turner 2010-11-28 01:24:18 UTC
Note : This has been mentioned on the Forums with no fix.. :
https://forums.gentoo.org/viewtopic-t-843358.html?sid=b51df510dccb449d2ecbe3942db859fa
Comment 2 David Turner 2010-11-28 01:25:36 UTC
Created attachment 255697 [details, diff]
Source patch correcting the hangup.
Comment 3 David Turner 2010-11-28 01:27:35 UTC
Created attachment 255699 [details]
Modified Ebuild For Overlay Test (Only change is to apply patch supplied)
Comment 4 David Turner 2010-11-28 01:28:36 UTC
Created attachment 255701 [details]
Original Patch from Arch Linux Bugtracker for Comparison - Note second section seems already applied in source code...
Comment 5 David Turner 2010-11-28 01:31:10 UTC
Note that 2.32.52 does _not_ correct this issue and the same or similar patch will be needed to be applied to this. 

The next stable release of Unison after this should not require this patch as it is in upstream SVN.
Comment 6 Felix Schuster 2010-11-28 17:19:25 UTC
I can confirm working of the patch, please provide this ebuild in the portage tree.
Comment 7 Aljoscha Vollmerhaus 2010-11-29 18:43:32 UTC
Arch patch works, amd64-desktop
Comment 8 WOLfgang Schricker 2010-11-30 21:55:20 UTC
Ebuild unison-2.27.57-r2 works fine for me. THX!
Comment 9 Till Schäfer 2010-12-07 21:30:16 UTC
Works good. No Problems. (3 PC)
Comment 10 Aljoscha Vollmerhaus 2010-12-14 11:08:20 UTC
Could we fix this in Portage? As this is definitely a tool that´s installed on multiple PCs per User, running arund applying the patch to all my machines is a tedious work.

"unison -ui text" still works for me, refraining from using the gui for now.
Comment 11 Tilman P 2010-12-20 13:50:38 UTC
(In reply to comment #10)
> Could we fix this in Portage? As this is definitely a tool that´s installed on
> multiple PCs per User, running arund applying the patch to all my machines is a
> tedious work.
> 
> "unison -ui text" still works for me, refraining from using the gui for now.
> 

Same here, could someone please add the patch to portage?
Comment 12 Christian Schmitt 2011-02-01 23:00:15 UTC
The patch is already in portage since august 2010. But here it doesn't fix the problem. Running unison 2.32.52.
Comment 13 Jérôme Revillard 2011-02-21 12:23:45 UTC
(In reply to comment #12)
> The patch is already in portage since august 2010. But here it doesn't fix the
> problem. Running unison 2.32.52.
> 

I'm sorry but I think that it's not. Indeed, if I apply it, my Unison works and without it, it doesn't...

Best.
Comment 14 Till Schäfer 2011-02-21 20:13:35 UTC
Please fix it in portage. Iam using the patch since 3.December 2010 without problems. The portage version 2.27.57-r1 does not work. 
Comment 15 Mario Chisari 2011-03-11 16:15:03 UTC
Above two comments are true: Unison 2.32.52 doesn't work on my system, with openssh 5.8_p1-r1. Had to create a new local ebuild, with a single line to patch source against this:

Index: src/terminal.ml
===================================================================
--- src/terminal.ml	(revision 471)
+++ src/terminal.ml	(working copy)
@@ -191,7 +191,6 @@
             exit 127
           end
       | childPid ->
-          Unix.close slaveFd;
           (Some masterFd, childPid)
       end
 
Now everything works again.

This should really be fixed; although gentoo user are skilled, I think they should spend their time in something more interesting than developing local ebuilds for trivial tasks...
Comment 16 Mario Chisari 2011-03-11 16:19:01 UTC
Created attachment 265573 [details]
Local ebuild for building a working unison 2.32.52

(quick-and-dirty; only a single line added: 36)
Comment 17 Felix Schuster 2011-03-21 15:35:13 UTC
(In reply to comment #15)
> This should really be fixed; although gentoo user are skilled, I think they
> should spend their time in something more interesting than developing local
> ebuilds for trivial tasks...

Well... is there anyone capable of doing this? it's really annoying particularly because there exists a solution.
Comment 18 C W Rose 2012-05-22 07:08:51 UTC
Could someone please add this patch to portage?  (At least
for the stable version of Unison.)  I put the fix into a
local overlay fifteen months ago, and then forgot about it,
so when I installed Gentoo recently I spent an hour running
around trying to find out (again) what had broken.

A one-line patch would save a lot of people a lot of work.

Thanks - Will
Comment 19 Daniel Bumke 2012-05-26 12:52:33 UTC
I can confirm that this patch applies cleanly to unison-2.13.16, unison-2.27.57, unison-2.27.157, and unison-2.32.52. No issues compiling or running these versions on x86. It has been applied by upstream to the 2.40 branch.
Comment 20 Till Schäfer 2012-05-26 15:31:21 UTC
we realy need to get forward whis this. patch is working here since a long time om several machines.
Comment 21 Oliver Jensen 2013-09-03 16:42:47 UTC
I agree... it's been more than a year (again). Is anyone on point for this sort of thing?

It's not like making a local overlay, downloading the patch etc is particularly difficult, but this one line fix would save a decent chunk of time
Comment 22 Benda Xu gentoo-dev 2013-09-09 08:21:03 UTC
Hi, thank you for the comments and patches.

I am using unison-2.40 myself, therefore not sure of this bug. I'd like to know why the upstream applied the patch to 2.40 but have not backported it to older versions.

To commit a patch (not to say I don't understand ocaml) I do not use/test myself does not feel good.

If you care about <unison-2.40 and want to maintain this patch, I'd be happy to proxy-maintain it. Or, which is much welcomed, becoming a developer to maintain unison.

Cheers!
Comment 23 Till Schäfer 2013-09-09 10:09:38 UTC
I don't think i can handle the dev thing for the lower versions, but at least the not working versions should be masked. Having a stable version that do not work at all seems to be worse than having only newer versions available (even if they are not stable).

On the other hand the patch seems to work for several people here flawless, Therefore i don't see the problem to apply it. Could this patch change introduce any security problems?

Maybe >2.40 should be stabilized too?!
Comment 24 C W Rose 2014-11-20 14:21:58 UTC
2.27.57-r1, the last stable version, is still broken on x86.  I see that I patched it locally in November 2011; I've just had another fight to get unison going because I'd forgotten it needed patching.  Be nice if the (one line) patch could make it into Portage; not everyone remembers the bugs of 2011.

Will
Comment 25 Pacho Ramos gentoo-dev 2016-05-06 10:08:01 UTC
this should be solved in the current versions in testing (stable keyword was dropped some time ago)