Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 34660 - RSYNC_EXCLUDEFROM causes emerge sync to crash
Summary: RSYNC_EXCLUDEFROM causes emerge sync to crash
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
: 36853 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-11-28 17:32 UTC by Daniel Lawson
Modified: 2011-10-30 22:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
changes mycommand to rsynccommand (emerge-excludefrom.patch,670 bytes, patch)
2003-11-28 17:39 UTC, Daniel Lawson 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Lawson 2003-11-28 17:32:05 UTC 
If the RSYNC_EXCLUDEFROM make.conf var is set and its destination exists, emerge
crashes due to badly formed code.

Reproducible: Always
Steps to Reproduce:
1. Add 'RSYNC_EXCLUDEFROM=/etc/portage/excludes' to /etc/make.conf
2. touch /etc/portage/excludes (or add some content)
3. run emerge sync

Actual Results:  
# emerge sync
Traceback (most recent call last):
  File "/usr/bin/emerge", line 1754, in ?
    mycommand=mycommand+" --exclude-from "+portage.settings["RSYNC_EXCLUDEFROM"]
NameError: name 'mycommand' is not defined

Expected Results:  
Run correctly, with '--exclude-from $file' included on the command line for
rsync, where $file is the filename specified in the RSYNC_EXCLUDEFROM config option.

Changing 'mycommand' to 'rsynccommand' at line 1754 in portage fixes this. 

Portage 2.0.49-r18 (default-x86-1.4, gcc-3.3.2, glibc-2.3.2-r9, 2.6.0-test9-1)
=================================================================
System uname: 2.6.0-test9-1 i686 AMD Athlon(tm) XP 1800+
Gentoo Base System version 1.4.3.12
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-mcpu=athlon-xp -O2 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3/share/config /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-mcpu=athlon-xp -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aalib apm arts avi berkdb bonobo cdr crypt cscope cups curl directfb
encode esd fbcon foomaticdb gb gd gdbm ggi gif gnome gphoto2 gpm gtk gtk2
gtkhtml guile imap imlib ipv6 java jikes jpeg lame ldap libg++ libwww mad mikmod
motif mozilla mpeg ncurses nls nocd oggvorbis opengl oss pam pdflib perl png pnp
python qt quicktime readline samba sdl slang spell sse ssl svga tcpd truetype
usb x86 xml2 xmms zlib"
Comment 1 Daniel Lawson 2003-11-28 17:39:30 UTC 
Created attachment 21429 [details, diff]
changes mycommand to rsynccommand
Comment 2 Masatomo Nakano (RETIRED) gentoo-dev 2003-11-28 17:47:33 UTC 
fixed in cvs.
Comment 3 SpanKY gentoo-dev 2003-12-30 20:05:26 UTC 
*** Bug 36853 has been marked as a duplicate of this bug. ***