346567 – sys-kernel/linux-headers will silently fail if unifdef crashes

Bug 346567 - sys-kernel/linux-headers will silently fail if unifdef crashes

Summary: sys-kernel/linux-headers will silently fail if unifdef crashes

Status:	VERIFIED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Toolchain Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-11-23 20:32 UTC by Diego Elio Pettenò (RETIRED)
Modified:	2010-11-23 22:37 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Build log (linux-headers-2.6.36:20101123-150215.log,113.80 KB, text/plain) 2010-11-23 20:33 UTC, Diego Elio Pettenò (RETIRED)	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Diego Elio Pettenò (RETIRED) gentoo-dev

2010-11-23 20:32:54 UTC

Don't ask me what's really going on in the tinderbox for this to have happened, let's just say that trying to get gold to work was definitely a mistake. On the other hand, it really shouldn't happen that a botched build of unifdef can cause all this trouble. It installs a number of empty files as headers, with the result that all the definition coming from linux-headers are missing.

Can we add at least a bit of safety check to ensure that there is some content in the headers before replacing them?

Thanks,
Diego

Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-11-23 20:33:35 UTC

Created attachment 255229 [details]
Build log

Comment 2 SpanKY gentoo-dev

2010-11-23 22:21:43 UTC

ive sent a patch upstream.  not planning on adding the patch to all the older ebuilds though since this is unlikely to occur.

Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev

2010-11-23 22:37:40 UTC

Thanks.