svgalib-1.9.25-r1 doesn't build on kernel 2.6.35-r4. It seems like someone has add a patch for gentoo unstable branch, without changing the revbump !!! Reproducible: Always Steps to Reproduce: 1.emerge -1 svgalib 2. 3. USE="kernel-helper -build" asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # asus1 choux # emerge --info =media-libs/svgalib-1.9.25-r1 Portage 2.1.8.3 (default/linux/x86/10.0, gcc-4.4.4, glibc-2.11.2-r3, 2.6.35-gentoo-r4 i686) ================================================================= System Settings ================================================================= System uname: Linux-2.6.35-gentoo-r4-i686-Intel-R-_Core-TM-2_Quad_CPU_Q8200_@_2.33GHz-with-gentoo-1.12.14 Timestamp of tree: Thu, 18 Nov 2010 23:45:01 +0000 ccache version 2.4 [enabled] app-shells/bash: 4.1_p7 dev-java/java-config: 2.1.11-r1 dev-lang/python: 2.6.5-r3, 3.1.2-r4 dev-util/ccache: 2.4-r7 dev-util/cmake: 2.8.1-r2 sys-apps/baselayout: 1.12.14-r1 sys-apps/sandbox: 2.3-r1 sys-devel/autoconf: 2.13, 2.65-r1 sys-devel/automake: 1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1 sys-devel/binutils: 2.20.1-r1 sys-devel/gcc: 4.4.4-r2 sys-devel/gcc-config: 1.4.1 sys-devel/libtool: 2.2.10 sys-devel/make: 3.81-r2 virtual/os-headers: 2.6.30-r1 ACCEPT_KEYWORDS="x86" ACCEPT_LICENSE="* -@EULA dlj-1.1 AdobeFlash-10 AdobeFlash-10.1" CBUILD="i686-pc-linux-gnu" CFLAGS="-O2 -march=core2 -pipe" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/X11/xkb /usr/share/config" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -march=core2 -pipe" DISTDIR="/home/data/src" FEATURES="assume-digests buildpkg ccache distlocks fixpackages news parallel-fetch protect-owned sandbox sfperms strict unmerge-logs unmerge-orphans userfetch" GENTOO_MIRRORS="ftp://ftp.free.fr/mirrors/ftp.gentoo.org/" LANG="fr_FR.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LINGUAS="fr" MAKEOPTS="-j5" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/var/lib/layman/python /var/lib/layman/tcl-multislot /var/lib/layman/sunrise /usr/local/portage/perso" SYNC="rsync://gentoo.modulix.net/gentoo-portage" USE="X acl alsa apache2 berkdb bzip2 cli cracklib crypt cups cvs cxx dbus dri dvd epydoc examples fortran gdbm gnome gpm gtk hal iconv intel ipod ipv6 jpeg kde ldap mad midi mmx modules mudflap mysql ncurses nls nptl nptlonly nsplugin openmp pam pcre perl ppds pppd python qt3 qt3support qt4 readline session sse sse2 ssl subversion sysfs tcl tcpd tk unicode usb vi vim-syntax x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="fr" PHP_TARGETS="php5-2" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="intel vesa fbdev" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS ================================================================= Package Settings ================================================================= media-libs/svgalib-1.9.25-r1 was built with the following: USE="kernel-helper -build"
And where is the build log? The patch is supposed to work properly with any kernel and for build fixes there is no need for revbumping. Let me have a look in the meantime.
That is my first bug, so i missed the log. But you do not need:the issue of the patch is the following +#else +static int svgalib_helper_ioctl(struct file *filp, + unsigned int cmd, unsigned long arg) { +#endif + struct inode *inode=filp->f_dentry->d_inode; should be +#else +static int svgalib_helper_ioctl(struct file *filp, + unsigned int cmd, unsigned long arg) { + struct inode *inode=filp->f_dentry->d_inode; +#endif
I committed an updated patch, should work now. Let me know (and reopen in case).
Revision 1.2 of the patch does work with kernel 2.6.35 thanks
But .... I clearly don't agree with you when you say: "for build fixes there is no need for revbumping" As a reminder (http://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html), "For ebuilds marked stable on at least one arch, only trivial edits can be made without a bump (e.g. typo fixes in elog messages). Even simple changes may result in a breakage. Modifying stable ebuilds should be avoided." Since two weeks, it was impossible to build svgalib on the stable branch. So, please 1/ Respect this rule and avoid to add this kind of patch 2/ *Test* your ebuild before any commit (that was clearly not the case here)
(In reply to comment #5) > I clearly don't agree with you when you say: > "for build fixes there is no need for revbumping" If it does not build, a fix can be made without revbumping, as no user has a broken instance installed. Next time, please don't cc people that are listed somewhere in the package's ChangeLog, I do stabilisations but no maintenance for svgalib.
The patch was wrong and that was clearly a mistake on my side (I produced the patch myself and forgot to double check it). We are human beings and as such, we make mistakes. I'm sure you did your own mistakes in your life. About the rest, please let us know a bit more than you about how to work things out.
And you failed at reassigning the bug anyway. This bug is still assigned to bug wranglers instead of me. Don't CC random people, also.
Fabio, you are right. sorry for my post.
