345723 – app-laptop/laptop-mode-tools unsuppressed stderr message

Bug 345723 - app-laptop/laptop-mode-tools unsuppressed stderr message

Summary: app-laptop/laptop-mode-tools unsuppressed stderr message

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High trivial (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:	http://mailman.samwel.tk/pipermail/la...
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-11-16 09:59 UTC by Witold Piłat
Modified:	2013-01-02 21:22 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Witold Piłat 2010-11-16 09:59:44 UTC

There is conditional in line 634 of /usr/sbin/laptop_mode which throws unnecesary stderr message on systems without hal (lid is handled by acpi anyway):

>if [ -x "`which hal-find-by-property`" ] ; then                                  >    HAL_LID_BUTTON=$(hal-find-by-property --key "button.type" --string "lid")    >fi

Reproducible: Always

Steps to Reproduce:
1. Set ENABLE_LAPTOP_MODE_WHEN_LID_CLOSED="1" in /etc/laptop-mode/laptop-mode.conf on system without hal
2. Restart laptop-mode
3.

Actual Results:  
which: no hal-find-by-property in (/lib64/rc/sbin:/lib64/rc/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin:/opt/bin)

Comment 1 Markos Chandras (RETIRED) gentoo-dev

2012-01-01 16:08:41 UTC

Thank you for your report. However, this bug has to be reported upstream first so they can fix it properly.

Comment 2 Pacho Ramos gentoo-dev

2013-01-02 21:22:57 UTC

Fixed in 1.62