Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 345379 - app-office/openoffice-3.2.1-r1: Add 'custum-optimization'
Summary: app-office/openoffice-3.2.1-r1: Add 'custum-optimization'
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High minor
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-14 10:51 UTC by dE
Modified: 2011-03-16 15:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dE 2010-11-14 10:51:33 UTC
I modified the ebuild of Ooo 2.3.1-r1 to remove the lines - 

filter-flags "-O[s2-9]"

and it compiled fine in my case, thus I suggest a custom-optimization use which will compile with the optimization as stated in make.conf.

Reproducible: Always

Steps to Reproduce:
Comment 1 Hanno Zysik (geki) 2010-11-14 15:33:51 UTC
I am playing with the same thought, do a safe build where flags are filtered completely. For the majority that just want it to complete. And for the rice cookies, add a flag to let it optimize, surely unsupported and easier to identify for the maintainer, if there was evil gcc flags involved.

Remember, there were cases where the code was silently miscompiled. That is hardly possible to maintain.


JFYI, the build environment adds '-O2' where appropriate and linker flags that do safe optimizations. And I bet they will add gcc graphite support to the modules that do improve by that. If the LO developers do not add that on their own, I will start a thread on the mailing list, asking for its usefulness. ;)
Comment 2 dE 2010-11-15 08:35:04 UTC
You may set the custom-optimization to - by default.
Comment 3 Hanno Zysik (geki) 2010-11-20 11:14:18 UTC
A nice example of wasting resources is bug 345799.

And we have had some more of these in the past. ;)
And what may come in the future.

Sorry to annoy, but ...
Comment 4 dE 2010-11-20 18:35:32 UTC
Maybe an ewarn can be added.
Comment 5 Hanno Zysik (geki) 2010-11-21 10:59:27 UTC
There is an ewarn about lowering flags if it fails. It is just ignored.
Comment 6 dE 2010-11-21 13:11:26 UTC
Then how about using read to prompt user input?

Using -custum-optimization (in EAPI3) is good enough. It can be even masked.
Comment 7 Andreas Proschofsky (RETIRED) gentoo-dev 2011-03-16 10:57:33 UTC
As we are going to deprecate openoffice not going to do this. But there's already a bug for libreoffice, so head over there ;-)

bug #355981
Comment 8 dE 2011-03-16 15:14:26 UTC
(In reply to comment #7)
> As we are going to deprecate openoffice not going to do this. But there's
> already a bug for libreoffice, so head over there ;-)
> 
> bug #355981

Are you sure? Are you even gonna remove the bin package? A lot of people need that for testing.
Comment 9 Andreas Proschofsky (RETIRED) gentoo-dev 2011-03-16 15:26:21 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > As we are going to deprecate openoffice not going to do this. But there's
> > already a bug for libreoffice, so head over there ;-)
> > 
> > bug #355981
> 
> Are you sure? Are you even gonna remove the bin package? A lot of people need
> that for testing.

Yes I'm sure. We didn't have a vanilla app-office/openoffice in the tree for years, libreoffice is the direct successor to what we had before in the OOo-package. And vanilla OOo is a real pain to build / maintain, basically would be a totally new package.

openoffice-bin on the other hand is going to stay for now.

But that's all very much off-topic here.