Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 344943 - app-portage/gentoolkit-dev: echangelog should check for CVS/svn first
Summary: app-portage/gentoolkit-dev: echangelog should check for CVS/svn first
Status: RESOLVED OBSOLETE
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 15:47 UTC by Michał Górny
Modified: 2017-11-03 08:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2010-11-10 15:47:44 UTC
Currently, the VCS detection code seems to check for VCSes in a lexical order, checking the full directory tree backwards for each of them. I think it would be better to either:

a) switch the loops -- i.e. check all VCSes for each dir, not all dirs for a VCS,
b) at least move CVS/svn checks elsewhere as they duplicate their directories in each repo dir.

This is a case e.g. whenever a subversion repositories is checked out within a larger git repo [1].

[1] https://github.com/mgorny/sunrise-commit/issues#issue/4
Comment 1 Christian Ruppert (idl0r) gentoo-dev 2012-04-09 01:47:37 UTC
subversion no longer uses the per directory .svn, it leaves only CVS and I'm not sure if it's worth to change.