Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 344533 - net-misc/asterisk-1.8.1.1 fails to fully enable MySQL; menuselect needed
Summary: net-misc/asterisk-1.8.1.1 fails to fully enable MySQL; menuselect needed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-07 15:13 UTC by Ivan L. Isaev
Modified: 2011-01-04 17:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for asterisk 1.8.1 (asterisk-1.8.1.ebuild,8.31 KB, text/plain)
2010-12-09 19:02 UTC, Ivan L. Isaev
Details
unified diff (asterisk-1.8.1.1.ebuild.patch,621 bytes, patch)
2010-12-30 18:25 UTC, Ivan L. Isaev
Details | Diff
menuselect.patch (menuselect-deps-and-mkdir.patch,1.17 KB, text/plain)
2010-12-31 18:04 UTC, Tony Vroon (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan L. Isaev 2010-11-07 15:13:34 UTC
cdr_mysql, res_config_mysql and app_mysql modules are now included in asterisk 1.8, There is no asterisk-addons-1.8. However, this modules is not compiling while emerge. configure --with-mysqlclient don't enable this modules..

Reproducible: Always

Steps to Reproduce:
1. USE="mysql" emerge net-misc/asterisk
2.
# ls /usr/lib/asterisk/modules | grep -c mysql
0
Actual Results:  
asterisk don't have app_mysql.so and cdr_mysql.so
Comment 1 Ivan L. Isaev 2010-11-07 15:27:44 UTC
to enable the modules:
menuselect/menuselect --enable app_mysql menuselect.makeopts
menuselect/menuselect --enable cdr_mysql menuselect.makeopts
menuselect/menuselect --enable res_config_mysql menuselect.makeopts
Comment 2 Ivan L. Isaev 2010-12-09 19:02:27 UTC
Created attachment 256765 [details]
ebuild for asterisk 1.8.1

ebuild for asterisk 1.8.1 which enables cdr_mysql, res_config_mysql and app_mysql modules when USE=mysql.
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2010-12-30 16:53:30 UTC
I'm sorry to have taken so long to provide you with feedback.
Please submit your changes as a unified diff and not as a complete ebuild; this makes it easier to review.

You seem to be making configuration changes in src_compile; as the name suggests this is strictly for compilation only. Your changes should be in src_configure instead. Note how everything else uses the use_with construct; are you sure your changes can not be applied this way?

Please supply any diffs against 1.8.1.1 which will be in the portage tree shortly.
Comment 4 Ivan L. Isaev 2010-12-30 17:16:58 UTC
> You seem to be making configuration changes in src_compile; as the name
> suggests this is strictly for compilation only. Your changes should be in
> src_configure instead. Note how everything else uses the use_with construct;
> are you sure your changes can not be applied this way?
You're right, changes should be in src_configure. I put menuselect in src_compile because my first attempt in src_configure was unsuccessful.

> Please supply any diffs against 1.8.1.1 which will be in the portage tree
> shortly.
> 
ok, I'll wait
Comment 5 Ivan L. Isaev 2010-12-30 18:25:40 UTC
Created attachment 258459 [details, diff]
unified diff

"make menuselect.makeopts" build menuselect binary
Comment 6 Tony Vroon (RETIRED) gentoo-dev 2010-12-31 18:04:36 UTC
Created attachment 258545 [details]
menuselect.patch

This is what I plan to commit as Asterisk 1.8.1.1; you will see your changes among two other changesets. I added comments & removed the unnecessary cd "${S}" (in this ebuild stage, you will start out in ${S} and none of the commands change that location).
Please let me know if you see any problems with these changes.
Comment 7 Ivan L. Isaev 2010-12-31 22:55:23 UTC
No problems, all good. thanks
Comment 8 Tony Vroon (RETIRED) gentoo-dev 2011-01-04 17:31:35 UTC
+*asterisk-1.8.1.1-r1 (04 Jan 2011)
+
+  04 Jan 2011; Tony Vroon <chainsaw@gentoo.org> -asterisk-1.8.0.ebuild,
+  -asterisk-1.8.1.1.ebuild, +asterisk-1.8.1.1-r1.ebuild:
+  As pointed out by Ivan L. Isaev in bug #344533, MySQL was not fully enabled.
+  Together with Michael Lesniewski I have redone all conditional statements
+  through menuselect instead of through use_with. Pre-creating directories in
+  the installation image allows parallel install with MAKEOPTS above -j1,
+  closes bug #350339 by rad0xicated@gmail.com. Kill USE=logrotate which snuck
+  back in. Kill USE=keepsrc as I do not believe it is used. Petition me through
+  a bug report if you disagree and present a clear use case. Nuke older 1.8
+  branch ebuilds, they are useless now because of a gtalk protocol change.