While doing bug 343751, I noticed that brltty-4.1 fails to build. Reproducible: Always Steps to Reproduce: 1. emerge brltty-4.1 Actual Results: Build fails. See attachment. Expected Results: Emerge successful and software installed without any problems. emerge --info Portage 2.1.8.3 (default/linux/x86/10.0, gcc-4.4.4, glibc-2.11.2-r3, 2.6.35 i686) ================================================================= System uname: Linux-2.6.35-i686-Mobile_AMD_Sempron-tm-_Processor_2800+-with-gentoo-1.12.13 Timestamp of tree: Sat, 06 Nov 2010 06:30:19 +0000 distcc 3.1 i686-pc-linux-gnu [enabled] app-shells/bash: 4.1_p7 dev-java/java-config: 2.1.11 dev-lang/python: 2.6.5-r3, 3.1.2-r4 dev-util/cmake: 2.8.1-r2 sys-apps/baselayout: 1.12.13 sys-apps/sandbox: 2.3-r1 sys-devel/autoconf: 2.13, 2.65-r1 sys-devel/automake: 1.10.3, 1.11.1 sys-devel/binutils: 2.20.1-r1 sys-devel/gcc: 4.4.4-r2 sys-devel/gcc-config: 1.4.1 sys-devel/libtool: 2.2.10 sys-devel/make: 3.81-r2 virtual/os-headers: 2.6.30-r1 ACCEPT_KEYWORDS="x86" ACCEPT_LICENSE="* -@EULA" CBUILD="i686-pc-linux-gnu" CFLAGS="-march=athlon-xp -O2 -pipe" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/X11/xkb" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=athlon-xp -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="assume-digests collision-protect distcc distlocks fixpackages news nostrip parallel-fetch protect-owned sandbox sfperms strict test unmerge-logs unmerge-orphans userfetch userpriv" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="nl_NL.UTF-8" LDFLAGS="-Wl,-O1,--as-needed" LINGUAS="nl en uk" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="7zip X acl acpi alsa autoipd avahi bash-completion berkdb bzip2 cairo cli cracklib crypt cxx dbus dri encode fam ffmpeg flac fortran fts3 gdbm gif gmp gnutls gpm gtk hal iconv icu imap ipv6 ithreads java5 jpeg libnotify mikmod mmx modules mp3 mudflap ncurses networking nls nptl nptlonly ogg openexr opengl openmp openssl pam pcre perl pic player png pppd python qt3support qt4 rdesktop readline sdl session smime sockets spell sqlite sqlite3 sse sse2 ssl startup-notification svg sysfs tcpd theora threads thunar timidity truetype unicode vnc vorbis x86 xcb xcomposite xft xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="nl en uk" PHP_TARGETS="php5-2" RUBY_TARGETS="ree18" USERLAND="GNU" VIDEO_CARDS="radeonhd radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Created attachment 253411 [details] Build log
ML team, can you take a look at this and let me know what needs to be done to fix it? A patch would be helpful if you can provide one. Thanks, William
Created attachment 265673 [details] build.log I just attempted this emerge, with the ocaml use flag, and here is the resulting build log. brltty emerges fine without the ocaml use flag.
you can probably remove the part: '-ldconf "$(OCAML_DESTDIR)/ld.conf"' at Bindings/Caml/Makefile.in:105 findlib_src_preinst tells it not to bother with that file with an env variable but its overriden by the command line in this case...
I tried that over here, and it works beautifully! The package emerges without issues. I wrote a tiny test program for the ocaml bindings, and it works. I can load the library, connect to the server, read the braille driver name, and so forth. That's as much as I can test on my own, since I don't have hardware.
Created attachment 266147 [details, diff] brltty-4.2-fix-ocaml-install.patch Patch based on Alexis Ballier's earlier comment.
Comment on attachment 266147 [details, diff] brltty-4.2-fix-ocaml-install.patch Chris, I am concerned about this patch because it probably would not be accepted upstream since it breaks their install target. I think the better way to go would be to write a patch that has a good chance of being accepted upstream as well so that we do not have to carry this patch for all future versions of brltty. A better patch would probably define a variable that contains -ldconf "$(OCAML_DESTDIR)/ld.conf" then use that variable in the install line. This way, we could override it from the command line.
@Alexis Ballier: How should the makefile be rewritten for upstream? Should the "-ldconf ..." be removed? Then, we can just rely on the setting of OCAMLFIND_LDCONF.
Created attachment 266303 [details] brltty-4.2-fix-ocaml-install-2.patch All, here is my proposal for a patch for this issue. Chris and Alexis, what do you think of this patch? Thanks, William
@WilliamH: This looks good. But as I said, I don't know much about findlib. It would be nice if we could insure that upstream would take advantage of the OCAMLFIND_LDCONF environment variable, but I'm not quite sure how to do that.
I used the patch from comment #9 and sent it upstream. Thanks for the report.
