Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 34440 - gftp-2.0.15 (and 2.0.16) crashes when ran on amd64 platform
Summary: gftp-2.0.15 (and 2.0.16) crashes when ran on amd64 platform
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: High normal
Assignee: AMD64 Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-26 10:36 UTC by Darryl Bleau
Modified: 2004-03-30 10:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
strace of gftp-2.0.16-r1 (gftp-strace,70.92 KB, text/plain)
2003-12-28 08:46 UTC, Thomas Petersen
Details
64-bit "fixes" for gftp 2.0.15. (gftp-2.0.15-64bit-fixes.patch,15.98 KB, patch)
2004-01-04 22:51 UTC, Ryan C. Gordon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darryl Bleau 2003-11-26 10:36:20 UTC
The emerge is successful for either 2.0.15 or 2.0.16 but the program will not run.

Reproducible: Always
Steps to Reproduce:
1. put gftp in portage overlay
2. emerge gftp
3. try to run gftp

Actual Results:  
(gftp-gtk:20906): Gtk-CRITICAL **: file gtkwidget.c: line 4101
(gtk_widget_get_style): assertion `GTK_IS_WIDGET (widget)' failed
 
(gftp-gtk:20906): Gtk-CRITICAL **: file gtkwidget.c: line 4101
(gtk_widget_get_style): assertion `GTK_IS_WIDGET (widget)' failed
Segmentation fault


Expected Results:  
Ran successfully
Comment 1 Chuck Short (RETIRED) gentoo-dev 2003-12-16 18:56:04 UTC
Can you attach an strace please, thanks.
Comment 2 Thomas Petersen 2003-12-28 08:46:37 UTC
Created attachment 22746 [details]
strace of gftp-2.0.16-r1

I have the same problem as Darryl.

emerge info:
Portage 2.0.49-r18 (default-amd64-1.4, gcc-3.3.2, glibc-2.3.3_pre20031222-r0,
2.6.0-gentoo)
=================================================================
System uname: 2.6.0-gentoo x86_64 4
Gentoo Base System version 1.4.3.12
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CFLAGS="-O2"
CHOST="x86_64-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3/share/config /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS=""
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://gentoo.bzimage.dk/pub/gentoo
ftp://ftp.uninett.no/pub/linux/Gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://gentoo.bzimage.dk/gentoo-portage"
USE="3dnow 3ds X Xaw3d aalib alsa amd64 apache2 apm arts avi berkdb cdr crypt
cups curl dga dv dvb dvd dvdr emacs emacs-w3 encode esd ethereal faad flash
foomaticdb gatos gd gdbm gif gnome gphoto2 gpm gstreamer gtk gtk2 gtkhtml imap
imlib innodb ipv6 java jpeg kde lcms libg++ libwww mad maildir matroska mikmod
mmx mng motif mozcalendar mozilla mozxmlterm mpeg multilib music mysql nas
ncurses nls odbc oggvorbis openal opengl oss pam pdflib perl png pnp postgres
python qt quicktime readline ruby samba sasl scanner sdl slang snmp spell sse
ssl tcpd tetex tiff truetype usb videos wmf xinerama xml xml2 xmms xosd xv
zlib"
Comment 3 Ryan C. Gordon 2004-01-04 22:49:16 UTC
This one is a stack corruption (plus, an incorrect g_free() in the error reporting when the stack corruption confuses things, which is probably where your actual crash came from).

gftp uses a mechanism for looking up configuration data that assumes sizeof (int) == sizeof (void *), so it blows up on 64-bit systems.

Here's a patch that changes all occurances of config lookups to store the lookup results in something that is sizeof (void *)...it's not the best solution, but hey, it's not my program.  :)  That g_free() call is fixed, too.

The patch makes gftp-2.0.15 work on amd64; I tried a quick anonymous FTP transfer and it worked fine...recommend this ebuild goes to ~amd64 with this patch and more testing be done; I'm not a gftp user myself, so this is the end of my testing.

I'll point the original gftp developers to this bug entry, too.

--ryan.

Comment 4 Ryan C. Gordon 2004-01-04 22:51:21 UTC
Created attachment 23173 [details, diff]
64-bit "fixes" for gftp 2.0.15.
Comment 5 George L. Emigh 2004-02-23 17:41:27 UTC
I applied the patch found here in the bug report to gftp-2.0.15 by adding the following to the ebuild:

src_unpack() {

    unpack ${A}

            cd ${S}
            epatch ${FILESDIR}/${P}-amd64.patch

}

The patch applied, and now gftp-2.0.15 works on amd64 for me, I'm able to login to accounts and it works as expected.

I'm sure others would like gftp on amd64.

-- George
Comment 6 Daniel Ahlberg (RETIRED) gentoo-dev 2004-02-25 04:20:22 UTC
Patch added to CVS, thanks!
Comment 7 Jeff Craig 2004-03-12 19:23:33 UTC
With this patch available, would it be possible to give gftp-2.0.15 the ~amd64 keyword?

I've installed and tested it, and everything appears to be in working order.
Comment 8 Richard Schreyer 2004-03-30 10:32:25 UTC
gftp 2.0.15 appears to work on amd64 but gftp 2.0.16_r1 does not.  This patch needs to be applied to that package as well.