I've just found bug 252894 which suggests this version will soon be removed from the tree, but I'd like to check that this is the appropriate fix, so I can continue trying to help out where I can (with other packages etc). When I recently tried to emerge net-libs/opal-2.2.11, I received this error: ================================================================================ >>> Completed installing opal-2.2.11 into /var/tmp/portage/net-libs/opal-2.2.11/image/ strip: i686-pc-linux-gnu-strip --strip-unneeded -R .comment usr/lib/libopal_linux_x86_n.so.2.2.11 * QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * /var/tmp/portage/net-libs/opal-2.2.11/work/opal-2.2.11/src/codec/gsm/src/code.c:98: warning: implicit declaration of function ‘memcpy’ * QA Notice: Package has poor programming practices which may compile * fine but exhibit random runtime failures. * /var/tmp/portage/net-libs/opal-2.2.11/work/opal-2.2.11/src/codec/gsm/src/code.c:98: warning: incompatible implicit declaration of built-in function ‘memcpy’ * Please do not file a Gentoo bug and instead report the above QA * issues directly to the upstream developers of this software. * Homepage: http://www.ekiga.org * ERROR: net-libs/opal-2.2.11 failed: * install aborted due to poor programming practices shown above * * Call stack: * misc-functions.sh, line 978: Called install_qa_check * misc-functions.sh, line 669: Called die * The specific snippet of code: * hasq stricter ${FEATURES} && die "install aborted due to" \ * * If you need support, post the output of 'emerge --info =net-libs/opal-2.2.11', * the complete build log and the output of 'emerge -pqv =net-libs/opal-2.2.11'. * The complete build log is located at '/var/tmp/portage/net-libs/opal-2.2.11/temp/build.log'. * The ebuild environment file is located at '/var/tmp/portage/net-libs/opal-2.2.11/temp/environment'. * S: '/var/tmp/portage/net-libs/opal-2.2.11/work/opal-2.2.11' !!! post install failed; exiting. >>> Failed to emerge net-libs/opal-2.2.11, Log file: >>> '/var/tmp/portage/net-libs/opal-2.2.11/temp/build.log' ================================================================================ After a poke around, it looks like this patch makes the above error go away for me. ================================================================================ --- opal-2.2.11/src/codec/gsm/src/code.c.orig 2010-11-05 00:46:16.000000000 +1300 +++ opal-2.2.11/src/codec/gsm/src/code.c 2010-11-05 00:47:55.000000000 +1300 @@ -10,8 +10,8 @@ #include "config.h" -#ifdef HAS_STDLIB_H -#include <stdlib.h> +#ifdef HAS_STRING_H +#include <string.h> #else # include "proto.h" extern char * memcpy P((char *, char *, int)); ================================================================================ Does that sound like the correct thing to send upstream?
Thank you for report. The fix looks correct. But in any case we don't fix old packages. So I'm closing this bug as is.
