Bug 343603 – media-sound/gsm-1.0.13 fails to build on Mac OS (patch attached)

• Status: VERIFIED FIXED
• Product: Gentoo/Alt

[Description Charles Davis 2010-11-01 01:00:44 UTC]

The GSM ebuild fails to build on Mac OS X. This is because it tries to use the Darwin patch for 1.0.12, which doesn't work on .13.

I've created a patch for .13 that should work.

Yes I know that gsm-1.0.13 is masked, and this is probably why.

Reproducible: Always

Steps to Reproduce:
1. Add the line 'media-sound/gsm **' to the package.keywords file.
2. emerge gsm

Actual Results:  
Patching fails because the Darwin patch hasn't been updated for .13 yet.

Expected Results:  
Patching should succeed and the build should continue as normal.

[Comment 1 Charles Davis 2010-11-01 01:01:52 UTC]

Created attachment 252731 [details, diff]
Patch to fix media-sound/gsm-1.0.13 build on Mac OS

[Comment 2 Fabian Groffen 2010-11-13 20:59:46 UTC]

thanks, I replaced the 1.0.12 patch with yours

[Comment 3 Charles Davis 2010-11-14 20:37:15 UTC]

Created attachment 254337 [details, diff]
New patch to fix media-sound/gsm-1.0.13 build on Mac OS

Sorry, my first patch doesn't apply cleanly. Here's a corrected patch.

You probably should have checked that this patch actually worked before putting it in ;).

[Comment 4 Charles Davis 2010-11-14 20:38:05 UTC]

The current patch in Portage doesn't apply cleanly. Reopening.

[Comment 5 Fabian Groffen 2010-11-15 08:36:03 UTC]

uh, oh... my bad

[Comment 6 Fabian Groffen 2010-11-15 08:48:31 UTC]

fixed again, I checked it applied this time :)