Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 342825 - sys-apps/openrc: allow user to extend net_fs_list instead of replacing it
Summary: sys-apps/openrc: allow user to extend net_fs_list instead of replacing it
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-26 21:12 UTC by William Hubbs
Modified: 2010-10-27 14:06 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Hubbs gentoo-dev 2010-10-26 21:12:40 UTC
All,

the git repository for openrc shows two different definitions of
net_fs_list as follows:

etc/rc.conf.in:net_fs_list="afs cifs coda davfs fuse fuse.sshfs gfs glusterfs lustre ncpfs nfs nfs4 ocfs2 shfs smbfs"
sh/rc-functions.sh.in:net_fs_list="afs cifs coda davfs fuse gfs ncpfs nfs nfs4 ocfs2 shfs smbfs"

I'm guessing that the first definition is correct and should be copied
to the second location.

This brings up another question however.  My understanding of this
variable is that it is a list of file system types for non-local file
systems.  Is this something we want to expose in rc.conf and allow users
to configure, or should we just maintain it internally in
rc-functions.sh and maybe have another variable if users want to add
their own filesystem types to the list?
Comment 1 SpanKY gentoo-dev 2010-10-27 00:37:36 UTC
yes, we want people to be able to control the list.  that was the whole point -- we dont want to have to maintain a huge random list of crap that people use.

a better idea though might be to have a base "net_fs_list" and only let the user extend it.
Comment 2 William Hubbs gentoo-dev 2010-10-27 14:06:32 UTC
(In reply to comment #1)
> a better idea though might be to have a base "net_fs_list" and only let the
> user extend it.

I just pushed a commit that makes this happen.  Now, in rc.conf, extra_net_fs_list can be used to extend the list of network fstypes.  This variable is added onto the end of our base list, which is set in rc-functions.sh.