Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 34223 - typo in portage.py causes displaying wrong path in error message
Summary: typo in portage.py causes displaying wrong path in error message
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Unclassified (show other bugs)
Hardware: All Linux
: High trivial
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2003-11-23 15:02 UTC by Dennis Nienhüser (RETIRED)
Modified: 2011-10-30 22:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser (RETIRED) gentoo-dev 2003-11-23 15:02:41 UTC 
there's a small typo in /usr/lib/python2.2/site-packages/portage.py on line 542,
function digestCheckFiles()
542: "myfile=basedir+"/"+x"
should be
542: "myfile=basedir+x"
as basedir already comes with slash at the end.

Reproducible: Always
Steps to Reproduce:
Comment 1 Marius Mauch (RETIRED) gentoo-dev 2003-11-24 20:49:14 UTC 
It's not guaranteed that basedir has a trailing slash, so we have to add one.
The generated path is still valid, but it wouldn't hurt to normalize it by changing the line to:

myfile = normpath(basedir+"/"+x)
Comment 2 Nicholas Jones (RETIRED) gentoo-dev 2003-11-28 05:26:30 UTC 
Fixed in cvs.
Comment 3 Dennis Nienhüser (RETIRED) gentoo-dev 2004-06-09 09:48:13 UTC 
It's not fixed or the fix was reverted at some point and still confuses people, see http://forums.gentoo.org/viewtopic.php?p=1225203#1225203 for an example.
Comment 4 Marius Mauch (RETIRED) gentoo-dev 2004-06-09 17:57:16 UTC 
fixed again
Comment 5 Brian Harring (RETIRED) gentoo-dev 2004-08-16 11:34:56 UTC 
fixed for a while (confirmed it in pre18).