Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 342189 - dev-util/valgrind-3.6.0 version bump
Summary: dev-util/valgrind-3.6.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Anthony Basile
URL: http://valgrind.org/docs/manual/dist....
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-22 13:30 UTC by Arseny Solokha
Modified: 2010-11-10 01:44 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from 3.5.0 to 3.6.0 (valgrind-3.6.0.ebuild.patch,3.37 KB, patch)
2010-10-24 09:54 UTC, Samuli Suominen (RETIRED)
Details | Diff
Proposed update for valgrind-3.5.0-local-labels.patch (valgrind-3.6.0-local-labels.patch,1.36 KB, patch)
2010-10-24 12:28 UTC, Arseny Solokha
Details | Diff
Proposed update for valgrind-3.5.0-non-exec-stack.patch (valgrind-3.6.0-non-exec-stack.patch,5.48 KB, patch)
2010-10-24 12:42 UTC, Arseny Solokha
Details | Diff
patch against valgrind-3.5.0-r1.ebuild (valgrind-3.6.0.ebuild.patch,3.70 KB, patch)
2010-11-03 22:14 UTC, Anthony Basile
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arseny Solokha 2010-10-22 13:30:44 UTC
Valgrind 3.6.0 released on October 21, 2010.  Release notes and list of fixed bugs are too big to copy them here, so follow URL to get them.

This bug also probably fixes #305351 and #301780.

Reproducible: Always
Comment 1 Dane Smith (RETIRED) gentoo-dev 2010-10-22 22:06:29 UTC
Assigning to maintainer-needed.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2010-10-24 09:54:18 UTC
Created attachment 251783 [details, diff]
Patch from 3.5.0 to 3.6.0

These will need to be ported to 3.6.0 because they don't apply anymore, but are still required:

- valgrind-3.5.0-local-labels.patch
- valgrind-3.5.0-non-exec-stack.patch

So no-go for tree as-is.
Comment 3 Arseny Solokha 2010-10-24 12:28:40 UTC
Created attachment 251795 [details, diff]
Proposed update for valgrind-3.5.0-local-labels.patch
Comment 4 Arseny Solokha 2010-10-24 12:42:03 UTC
Created attachment 251797 [details, diff]
Proposed update for valgrind-3.5.0-non-exec-stack.patch

Missing patches uploaded.  Please test.
Comment 5 Steffen Schaumburg 2010-10-26 20:45:16 UTC
Valgrind installed with these patches works for me on amd64 with a vala program, thanks :)
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2010-11-01 22:21:34 UTC
I'd also like to ask for hardened support (need NOMPROPECT for all valgrind plugins).

Valgrind needs RWX for:
* large memory regions to emulate whole program w/o kernel assisted pagefaults
* runtime code generation (libvex)
Comment 7 Anthony Basile gentoo-dev 2010-11-01 23:18:11 UTC
(In reply to comment #6)
> I'd also like to ask for hardened support (need NOMPROPECT for all valgrind
> plugins).
> 
> Valgrind needs RWX for:
> * large memory regions to emulate whole program w/o kernel assisted pagefaults
> * runtime code generation (libvex)
> 

I recently took this package over.  I'll take care of this tomorrow.  I will add the hardened support as in bug #341599
Comment 8 Anthony Basile gentoo-dev 2010-11-03 22:07:18 UTC
Okay, I looked at this a bit more.  Both valgrind-3.6.0-local-labels.patch and valgrind-3.6.0-non-exec-stack.patch are fine.  I've change valgrind-3.6.0.ebuild.patch a bit because:

1. configure.in has changed its CFLAGS line to CFLAGS="-Wno-long-long $CFLAGS" which already inherits Gentoo's CFLAGS.  We don't need

sed -i -e 's:^CFLAGS="-Wno-long-long":CFLAGS="$CFLAGS -Wno-long-long":' configure.in

2. Just in case, I also removed CPPFLAGS= from mpi/Makefile.am so that CPPFLAGS are respected too.

3. I forward ported the pax-mark m for hardened from 3.5.0-r1

4. I added KEYWORD ~arm because according to upstream changelog arm-linux arch is now supported.

I tested this on a vanilla x86 and hardened x86 using the following code and got the expected results:

#include <iostream>
using namespace std ;

int main() {
	for(int i=0;i<1024;i++)
	{
		const unsigned MAX = 4096 ;
		char *dvalues = new char[MAX] ;
		//delete [] dvalues ; //BEWARE!!!
	}
	return 0 ;
}


I'll leave this stuff up for people to look at for a few days and if there are no problems, I'll put it on the tree.

Patch to ebuild in the next post ...
Comment 9 Anthony Basile gentoo-dev 2010-11-03 22:14:08 UTC
Created attachment 253079 [details, diff]
patch against valgrind-3.5.0-r1.ebuild
Comment 10 Sergei Trofimovich (RETIRED) gentoo-dev 2010-11-04 05:20:31 UTC
> !dev-util/callgrind"

do we need it?
Comment 11 Anthony Basile gentoo-dev 2010-11-04 11:49:58 UTC
(In reply to comment #10)
> > !dev-util/callgrind"
> 
> do we need it?
> 

Doesn't look like it.  Its gone!
Comment 12 Sergei Trofimovich (RETIRED) gentoo-dev 2010-11-04 20:04:32 UTC
> 4. I added KEYWORD ~arm because according to upstream changelog arm-linux arch
> is now supported.

Maybe, it would be better to ask arm arch team to keyword it.
valgrind is either very picky about supported arm families or has broken autotools host detector:

checking for a supported version of gcc... ok (5)
checking build system type... armv5tel-softfloat-linux-gnueabi
checking host system type... armv5tel-softfloat-linux-gnueabi
checking for a supported CPU... no (armv5tel)
configure: error: Unsupported host architecture. Sorry
Comment 13 Sergei Trofimovich (RETIRED) gentoo-dev 2010-11-04 20:07:30 UTC
> checking for a supported version of gcc... ok (5)
> checking build system type... armv5tel-softfloat-linux-gnueabi
> checking host system type... armv5tel-softfloat-linux-gnueabi
> checking for a supported CPU... no (armv5tel)
> configure: error: Unsupported host architecture. Sorry

Taken a look at configure.in:

case "${host_cpu}" in
...
     armv7*)
        AC_MSG_RESULT([ok (${host_cpu})])
        ARCH_MAX="arm"
        ;;

     *) 
        AC_MSG_RESULT([no (${host_cpu})])
        AC_MSG_ERROR([Unsupported host architecture. Sorry])
        ;;
esac

So, it dislikes my box.
Comment 14 Zeev Tarantov 2010-11-04 22:06:43 UTC
@ comment #13:

From the release notes (http://valgrind.org/docs/manual/dist.news.html):

* Support for ARM/Linux.  Valgrind now runs on ARMv7 capable CPUs
  running Linux.  It is known to work on Ubuntu 10.04, Ubuntu 10.10,
  and Maemo 5, so you can run Valgrind on your Nokia N900 if you want.

  This requires a CPU capable of running the ARMv7-A instruction set
  (Cortex A5, A8 and A9).  Valgrind provides fairly complete coverage
  of the user space instruction set, including ARM and Thumb integer
  code, VFPv3, NEON and V6 media instructions.  The Memcheck,
  Cachegrind and Massif tools work properly; other tools work to
  varying degrees.

It's for the newish smartphones only. Maybe contributed by Android people or something. I say let arm team decide.
Comment 15 Anthony Basile gentoo-dev 2010-11-04 22:09:55 UTC
@arm arch team

valgrind-3.6.0 adds arm support (according to the ChangeLog).  Should I include ~arm in KEYWORDS, or let you guys add it?
Comment 16 Anthony Basile gentoo-dev 2010-11-10 01:44:07 UTC
I just committed this to the tree without ~arm.

I'm going to close this bug because it was about a version bump.  If people want to get ~arm keywording, please open another enhancement bug.