Bug 342161 – =app-laptop/thinkpad-5.9-r1 doesn't build with kernel 2.6.36

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Christian Ruppert (idl0r) 2010-10-22 09:38:10 UTC]

=app-laptop/thinkpad-5.9-r1 doesn't build with kernel 2.6.36.

[Comment 1 Christian Ruppert (idl0r) 2010-10-22 09:39:58 UTC]

Created attachment 251537 [details]
build.log

[Comment 2 Steev Klimaszewski (RETIRED) 2010-10-22 14:21:53 UTC]

Thanks for the report, I haven't compiled 2.6.36 on my thinkpad yet (just installed the sources last night), so I'm not sure what change broke it.

[Comment 3 Mateusz Dziadko 2010-11-18 23:58:24 UTC]

=app-laptop/thinkpad-5.9-r1 doesn't build with linux-2.6.36-gentoo-r1

[Comment 4 Mateusz Dziadko 2010-11-19 00:04:00 UTC]

I wrote a quick patch to make it working. (converting ioctl to unlocked_ioctl)

[Comment 5 Mateusz Dziadko 2010-11-19 00:04:04 UTC]

Created attachment 254771 [details, diff]
Change ioctl to unlocked_ioctl ops

Change ioctl to unlocked_ioctl ops

[Comment 6 Mateusz Dziadko 2010-11-19 00:36:18 UTC]

Created attachment 254775 [details, diff]
Patch

Sorry, I sent the wrong file. This is correct.

[Comment 7 John Stile 2010-12-07 05:58:18 UTC]

Is there an ebuild bump for this yet?

[Comment 8 Robert G. Siebeck 2010-12-13 19:54:27 UTC]

Created attachment 257047 [details]
ebuild using attached patch

Attached ebuild using the patch, put patch into files subdirectory.

[Comment 9 Kfir Lavi 2010-12-21 14:52:38 UTC]

Hi,
I had the same problem, so thanks for this patch.
I have downloaded and ran this patch and it works good. 
I didn't noticed something odd, but didn't tested this module throughly. 
You should change the name of the patch from thinkpad-5.9.patch to thinkpad-ioctl_to_unlocked_ioctl-Gentoo.Bug.342161-5.9.patch or something similar.

Thanks,
Kfir

[Comment 10 Cyprien Nicolas (fulax) 2011-01-04 15:49:36 UTC]

Thanks Robert ! works for me too

[Comment 11 John Stile 2011-03-23 15:47:34 UTC]

This worked for me on  linux-2.6.36-gentoo with one minor change to the ebuild.

I had to add:
EAPI=3

[Comment 12 John Stile 2011-03-23 15:48:41 UTC]

(In reply to comment #11)
> This worked for me on  linux-2.6.36-gentoo with one minor change to the ebuild.
> 
> I had to add:
> EAPI=3

Sorry... I mean this worked on linux-2.6.38-gentoo.
Can we get a bump?

[Comment 13 Christian Ruppert (idl0r) 2011-04-06 14:42:30 UTC]

*** Bug 362277 has been marked as a duplicate of this bug. ***

[Comment 14 Marco Albanese 2011-04-11 06:13:14 UTC]

This worked for me on linux-2.6.37.

[Comment 15 Steev Klimaszewski (RETIRED) 2011-04-11 07:20:54 UTC]

idl0r if you want to take over this package, I haven't had the thinkpad of mine booted up in ages, so I don't think I can really take care of this package properly.

[Comment 16 Markos Chandras (RETIRED) 2011-06-26 09:15:31 UTC]

Just fyi, this package seems to be obsolete and replaced by app-laptop/tp_smapi. Did you try that? Maybe app-laptop/thinkpad is a good candidate for removal

[Comment 17 Markos Chandras (RETIRED) 2011-06-26 09:35:40 UTC]

In any case, I applied the patch but I have no x86 hardware to test it. Reopen if needed