Bug 342009 – =dev-lang/xsb-3.2-r1 QA improvements

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Agostino Sarubbo 2010-10-21 13:01:10 UTC]

In view of the stabilization of this package ( bug 341963 ) when I watching the ebuild I noticed thees improvements:

Add die after do* functions;
Remove die after econf (devman indicates that it does not need);
Replace make with emake;
Remove -j1 after emake;

About this last point I have tested and works without -j1 (on amd64).

I have attached a patch, feel free to take inspiration from that if deemed incorrect.

Thanks
ago

[Comment 1 Agostino Sarubbo 2010-10-21 13:01:31 UTC]

Created attachment 251445 [details]
Ebuild patch

[Comment 2 Keri Harris 2010-11-01 05:41:48 UTC]

Thanks for taking the time to give XSB ebuild a QA tidyup. I'll endeavour to review it over the next few days.

Keri

[Comment 3 Keri Harris 2010-11-02 06:03:50 UTC]

I've committed an updated ebuild to CVS. It contains all your changes except the -j1 removals. (The XSB packages need to be compiled single threaded due to the way the Prolog kernel's preamble and postamble is defined).

Thanks for the patch!

Keri

[Comment 4 Agostino Sarubbo 2010-11-02 08:56:20 UTC]

you're welcome ;)