Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 341091 - dev-lang/v8 add USE="debug"
Summary: dev-lang/v8 add USE="debug"
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Chromium Project
URL: http://code.google.com/p/v8/issues/de...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-15 06:20 UTC by Johan Bergström
Modified: 2010-11-22 16:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bergström 2010-10-15 06:20:50 UTC
Here's a quick diff that wraps debugsupport, profilingsupport in a debug use flag. I think these should be off by default.

--- /usr/portage/dev-lang/v8/v8-2.4.3.ebuild	2010-10-08 13:35:31.000000000 +0200
+++ v8-2.4.9.1.ebuild	2010-10-15 08:17:26.000000000 +0200
@@ -14,7 +14,7 @@
 
 SLOT="0"
 KEYWORDS="~amd64 ~x86"
-IUSE="readline"
+IUSE="debug readline"
 
 RDEPEND="readline? ( >=sys-libs/readline-6.1 )"
 DEPEND="${RDEPEND}
@@ -70,6 +70,8 @@
 		myconf="${myconf} console=dumb"
 	fi
 
+	use debug || myconf="${myconf} debuggersupport=off profilingsupport=off"
+
 	scons library=shared $(v8_scons_opts) ${myconf} . || die
 }
Comment 1 Johan Bergström 2010-10-15 06:40:46 UTC
Unfortunately both 2.4.3 and 2.4.9.1 builds seem to fail while turning the flags off:

g++ -o obj/release/d8-debug.os -c -O2 -pipe -fno-strict-aliasing -Wall -W -Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m64 -fomit-frame-pointer -fdata-sections -ffunction-sections -ansi -fno-rtti -fno-exceptions -fvisibility=hidden -Wall -W -Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m64 -fomit-frame-pointer -fdata-sections -ffunction-sections -ansi -fPIC -DV8_TARGET_ARCH_X64 -DV8_SHARED -Isrc src/d8-debug.cc
In file included from src/d8-debug.cc:30:
src/d8-debug.h:39: error: variable or field 'HandleDebugEvent' declared void
src/d8-debug.h:39: error: 'DebugEvent' was not declared in this scope
src/d8-debug.h:40: error: expected primary-expression before 'exec_state'
src/d8-debug.h:41: error: expected primary-expression before 'event_data'
src/d8-debug.h:42: error: expected primary-expression before 'data'
src/d8-debug.cc:43: error: variable or field 'HandleDebugEvent' declared void
src/d8-debug.cc:43: error: 'DebugEvent' was not declared in this scope
src/d8-debug.cc:44: error: expected primary-expression before 'exec_state'
src/d8-debug.cc:45: error: expected primary-expression before 'event_data'
src/d8-debug.cc:46: error: expected primary-expression before 'data'
src/d8-debug.cc:356: error: expected '}' at end of input
scons: *** [obj/release/d8-debug.os] Error 1
scons: building terminated because of errors.

I'll look into it and will most likely file an upstream bug when I got something useful to add
Comment 2 Johan Bergström 2010-10-15 08:11:31 UTC
No new info (i suck too much at c++), but at least upstream notification: http://code.google.com/p/v8/issues/detail?id=899
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2010-11-22 16:21:01 UTC
Please re-open when upstream fixes the issue.