340873 – kde-base/kdelibs-4.5.2: "Qt_VERSION" is not defined

Bug 340873 - kde-base/kdelibs-4.5.2: "Qt_VERSION" is not defined

Summary: kde-base/kdelibs-4.5.2: "Qt_VERSION" is not defined

Status:	RESOLVED UPSTREAM

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo KDE team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-10-13 17:59 UTC by Sebastian Pipping
Modified:	2010-10-16 09:16 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sebastian Pipping gentoo-dev

2010-10-13 17:59:27 UTC

I stumbled upon this warning in a compile log:

  [ 30%] [..]/work/kdelibs-4.5.2/kdeui/itemviews/kselectionproxymodel.cpp:2441:5: warning: "Qt_VERSION" is not defined

The involved code is this:

      if (!sourceModel() || index.column() > 0
  #if Qt_VERSION > 0x040700
         || d->m_rootIndexList.isEmpty()
  #endif
      )
          return 0;

If I'm not all wrong "Qt_VERSION" must be "QT_VERSION", right?

Comment 1 Theo Chatzimichos (RETIRED) archtester

2010-10-16 09:16:25 UTC

Indeed it is, but please report it upstream directly, no need for us to patch it