Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 34077 - fixheadtails.eclass reworked.
Summary: fixheadtails.eclass reworked.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: John Mylchreest (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-21 19:42 UTC by Mr. Bones. (RETIRED)
Modified: 2004-04-02 06:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
re-worked fixheadtails.eclass (fixheadtails.eclass,1.02 KB, text/plain)
2003-11-21 19:44 UTC, Mr. Bones. (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mr. Bones. (RETIRED) gentoo-dev 2003-11-21 19:42:59 UTC
Here's a version of fixheadtails.eclass that is smaller then the one in portage
now.  It depends on sed >= 4 for sed -i and checks the status of the disk io
that is used to fix the files.  It uses it's own functions internally.  The
ht_fix_file function was modified to skip the grep since the files are explicitly
named.  It shouldn't hurt to sed the file without checking it with grep and  it
allows ht_fix_all to call it.  cut was replaced with grep -l since that seems to
be what it was being used for anyhow.  putting the sed in it's own function means
we only have to get it right once instead of twice.

Should be a drop-in replacement for the existing eclass.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2003-11-21 19:44:08 UTC
Created attachment 21068 [details]
re-worked fixheadtails.eclass

...and the attachment.
Comment 2 John Mylchreest (RETIRED) gentoo-dev 2003-11-23 04:04:59 UTC
I have no argument with this being included.
Please check out the bug: http://bugs.gentoo.org/show_bug.cgi?id=23116
as well as Azarah made some good points about certain examples which wont be caught.
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2004-03-24 12:34:26 UTC
I think this can be closed unless you're still tracking it John.
Comment 4 John Mylchreest (RETIRED) gentoo-dev 2004-04-02 06:33:12 UTC
thanks for your time on this :D