Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 34052 - revdep-rebuild uses stale cache files
Summary: revdep-rebuild uses stale cache files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
: 95274 (view as bug list)
Depends on: 62644
Blocks:
  Show dependency tree
 
Reported: 2003-11-21 12:34 UTC by Jason Rhinelander
Modified: 2006-01-17 19:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
revdep-rebuild patch to check for stale .revdep-rebuild.* files (revdep-too-old.patch,5.45 KB, patch)
2003-11-21 12:36 UTC, Jason Rhinelander
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Rhinelander 2003-11-21 12:34:02 UTC
I've noticed when using revdep-rebuild that it will use the .revdep-rebuild.* files in /root, even when those files are potentially months old.  Generally, I do something like this:

revdep-rebuild -p

That often lists vmware, or openoffice-bin on my system, both of which I know are pointless to reinstall.  If openoffice-bin is the only one in the list, I don't run revdep-rebuild without -p, and so the .revdep-* files aren't deleted.  The problem is that if I come back a month later and run it with -p again, it doesn't scan anything and just uses the .revdep-* files, even though my system could be drastically different from what it was a month ago.

The fix for this is simple - just ignore the .revdep-rebuild.* files if they are more than 24 hours old.

I've created a patch against the revdep-rebuild that comes with gentoolkit-0.1.36 that checks the time of the files and doesn't use them if they are more than a day old - changing the 1 day timeout is a matter of simply changing the value of the TOO_OLD variable near the beginning.  The patch also includes a couple of indenting fixes where if statements weren't indented.
Comment 1 Jason Rhinelander 2003-11-21 12:36:29 UTC
Created attachment 21047 [details, diff]
revdep-rebuild patch to check for stale .revdep-rebuild.* files

(This is a repeat of the initial bug report, but with wrapped lines):

I've noticed when using revdep-rebuild that it will use the .revdep-rebuild.*
files in /root, even when those files are potentially months old.  Generally, I

do something like this:

revdep-rebuild -p

That often lists vmware, or openoffice-bin on my system, both of which I know
are pointless to reinstall.  If openoffice-bin is the only one in the list, I
don't run revdep-rebuild without -p, and so the .revdep-* files aren't deleted.

The problem is that if I come back a month later and run it with -p again, it
doesn't scan anything and just uses the .revdep-* files, even though my system
could be drastically different from what it was a month ago.

The fix for this is simple - just ignore the .revdep-rebuild.* files if they
are more than 24 hours old.

I've created a patch against the revdep-rebuild that comes with
gentoolkit-0.1.36 that checks the time of the files and doesn't use them if
they are more than a day old - changing the 1 day timeout is a matter of simply

changing the value of the TOO_OLD variable near the beginning.	The patch also
includes a couple of indenting fixes where if statements weren't indented.
Comment 2 Daniel Black (RETIRED) gentoo-dev 2004-10-02 07:15:56 UTC
Assigned to non-devs - reassigning so these may be noticed. 
Comment 3 Paul Varner (RETIRED) gentoo-dev 2005-11-03 19:31:56 UTC
Fix is in >gentoolkit-0.2.1_pre4
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2005-12-03 09:03:39 UTC
*** Bug 95274 has been marked as a duplicate of this bug. ***
Comment 5 Paul Varner (RETIRED) gentoo-dev 2006-01-17 19:03:10 UTC
Fixed in gentoolkit-0.2.1