Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 340347 - einstall specification is incomplete
Summary: einstall specification is incomplete
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: PMS/EAPI (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: PMS/EAPI
URL:
Whiteboard:
Keywords:
: 263798 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-10-10 13:28 UTC by Ulrich Müller
Modified: 2012-04-27 20:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for PMS (0001-Fix-listing-for-einstall-bug-340347.patch,812 bytes, patch)
2012-03-18 17:21 UTC, Ulrich Müller
Details | Diff
Patch for PMS (0001-Fix-listing-for-einstall-bug-340347.patch,1.27 KB, patch)
2012-03-18 18:42 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2010-10-10 13:28:49 UTC
PMS says that einstall would be equivalent to the following:

emake \
   prefix="${ED}"/usr \
   mandir="${ED}"/usr/share/man \
   infodir="${ED}"/usr/share/info \
   libdir="${ED}"/usr/$(get_libdir) \
   "$@" \
   install

However, portage assigns additional variables "datadir", "localstatedir", and "sysconfdir":

   prefix="${D}"/usr \
   datadir="${D}"/usr/share \
   infodir="${D}"/usr/share/info \
   localstatedir="${D}"/var/lib \
   mandir="${D}"/usr/share/man \
   sysconfdir="${D}"/etc \

This was already the case in portage-2.0.50 (from 2004).

Current portage also adds a "-j1" to options (2.0.50 didn't do that, but it called plain make without MAKEOPTS).

Also PMS shouldn't refer to $(get_libdir) which is a function from multilib.eclass.
Comment 1 Ulrich Müller gentoo-dev 2012-03-18 17:21:41 UTC
Created attachment 305807 [details, diff]
Patch for PMS
Comment 2 Ciaran McCreesh 2012-03-18 17:26:08 UTC
IIRC this was changed after we wrote PMS. Also, there's something horrible for get_libdir. So it's not that simple.
Comment 3 Ulrich Müller gentoo-dev 2012-03-18 18:05:45 UTC
(In reply to comment #2)
> IIRC this was changed after we wrote PMS.

You don't remember correctly: the three mentioned variables have always been set since 2004 and portage-2.0.50 (at least).

> Also, there's something horrible for get_libdir. So it's not that simple.

Right, I forgot. We probably must refer to Algorithm 10 <http://dev.gentoo.org/~ulm/pms/4/pms.html#x1-137001r10>.
Comment 4 Ulrich Müller gentoo-dev 2012-03-18 18:42:00 UTC
Created attachment 305811 [details, diff]
Patch for PMS

Updated patch, taking care of libdir.
Comment 5 Ulrich Müller gentoo-dev 2012-03-23 08:08:32 UTC
Committed.
Comment 6 Ulrich Müller gentoo-dev 2012-04-27 20:58:59 UTC
*** Bug 263798 has been marked as a duplicate of this bug. ***