Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 339789 - sys-kernel/genkernel-3.4.10.907, arithmetic bug in /usr/share/genkernel/defaults/initrd.scripts
Summary: sys-kernel/genkernel-3.4.10.907, arithmetic bug in /usr/share/genkernel/defau...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 351772
  Show dependency tree
 
Reported: 2010-10-05 08:32 UTC by Kolbjørn Barmen
Modified: 2011-01-16 17:27 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kolbjørn Barmen 2010-10-05 08:32:08 UTC 
Line 570 in /usr/share/genkernel/defaults/initrd.scripts says:

        if [ "${USE_MDADM}" -eq '1' ]

this should be

        if [ "${USE_MDADM}" = '1' ]

as "${USE_MDADM}" might be an empty string, and then -eq will fail.

There are other simliar checks in the same script, and they all use = instead of -eq.

Reproducible: Always
Comment 1 Sebastian Pipping gentoo-dev 2011-01-11 13:35:12 UTC 
Excellent catch, thanks for reporting.

This has been fixed on the experimental branch exposed by genkernel-99999 (five nines).

http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=532dd7a3871e389351d115fb19db73532bb6dd5b