Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 339638 - >=app-shells/tcsh-6.16: unnecessary atoms in RDEPEND
Summary: >=app-shells/tcsh-6.16: unnecessary atoms in RDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-03 22:39 UTC by Kevin Pyle
Modified: 2010-10-08 14:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pyle 2010-10-03 22:39:05 UTC
In tcsh-6.16.ebuild v1.4, jer@g.o added an explicit RDEPEND="$DEPEND".  While good in theory, the effect is incorrect in this case.  The tcsh ebuild uses perl to generate HTML documentation, so DEPEND includes "doc? ( dev-lang/perl )".  Similarly, it uses gettext during the build, but has no apparent need for it at runtime.  Due to the way that RDEPEND is set, Portage wants to install gettext and perl even if I install tcsh from a prebuilt package.  I think the correct dependencies are:

RDEPEND=">=sys-libs/ncurses-5.1"
DEPEND="${RDEPEND}
    sys-devel/gettext
    doc? ( dev-lang/perl )"

This would ensure that gettext and perl are still made available during the build, but would restrict the runtime dependency to cover only ncurses, which is needed since tcsh is dynamically linked to /lib/libncurses.so.5.
Comment 1 Fabian Groffen gentoo-dev 2010-10-06 07:46:06 UTC
thanks, I cleaned up RDEPEND now
Comment 2 Kevin Pyle 2010-10-07 03:57:37 UTC
I see the changes you made, but I think you missed one step.  As of now, the text of tcsh-6.16 is:

22 	RDEPEND=">=sys-libs/ncurses-5.1
23 	virtual/libiconv"
24 	DEPEND="${RDEPEND}
25 	sys-devel/gettext
26 	perl? ( dev-lang/perl )"
27 	RDEPEND="${DEPEND}"

I agree with lines 22-26, but I think line 27 prevents your changes from being effective at fixing the originally reported problem, since it overwrites the fixed RDEPEND with the same bad excessive atoms.

All the other versions look good to me.
Comment 3 Fabian Groffen gentoo-dev 2010-10-08 14:29:11 UTC
bah, sloppy work from my side.  Thanks, should be removed now.