339426 – app-emacs/ddskk-14.1 (version bump)

Bug 339426 - app-emacs/ddskk-14.1 (version bump)

Summary: app-emacs/ddskk-14.1 (version bump)

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High enhancement (vote)
Assignee:	CJK Team

URL:
Whiteboard:
Keywords:	EBUILD

Depends on:
Blocks:

Reported:	2010-10-02 05:35 UTC by katabami
Modified:	2010-11-04 14:04 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
ddskk-14.1.ebuild (ddskk-14.1.ebuild,1.34 KB, text/plain) 2010-10-03 00:53 UTC, katabami	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description katabami 2010-10-02 05:35:44 UTC

The upstream of app-emacs/ddskk has released version 14.1. Let me send an ebuild.

To use ddskk in emacs-23, this version is better that the 13.1, the
latest in portage tree.  They recommend emacs-22 and 23. Other than
that, at least either of 20.7, 21.4, XEmacs 21.4, or XEmacs 21.5 (or
greater) is required. XEmacs needs mule flag on.

Thanks beforehand.


Reproducible: Always

Comment 1 katabami 2010-10-03 00:53:45 UTC

Created attachment 249390 [details]
ddskk-14.1.ebuild

Attached an ebuild.

Comment 2 Ulrich Müller gentoo-dev

2010-10-03 09:23:44 UTC

(In reply to comment #1)
> Created an attachment (id=249390) [details]
> ddskk-14.1.ebuild

Thank you. Ebuild looks good to me, except for these minor points:

1. KEYWORDS normally shouldn't be dropped when doing a version bump.
2. In src_compile, BYTECOMPFLAGS is assigned twice. The second assignment seems
   to be unnecessary.
3. Please break overlong lines (like the one with the elisp_install command).

Comment 3 katabami 2010-10-05 01:22:04 UTC

Oops, I'm sorry for these 3 points. Thanks a lot for reviewing.

Comment 4 MATSUU Takuto (RETIRED) gentoo-dev

2010-11-04 14:04:26 UTC

in cvs. thanks