339352 – net-p2p/deluge-1.3.0 init.d scripts has bashisms

Bug 339352 - net-p2p/deluge-1.3.0 init.d scripts has bashisms

Summary: net-p2p/deluge-1.3.0 init.d scripts has bashisms

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High enhancement (vote)
Assignee:	Gentoo net-p2p team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-10-01 13:48 UTC by Paolo Pedroni
Modified:	2010-10-02 16:54 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to fix bashisms in init script (deluged-nobashism.patch,1.21 KB, patch) 2010-10-01 13:49 UTC, Paolo Pedroni	Details \| Diff
Simplify user & group mangling (0001-Simplify-user-group-mangling.patch,1.85 KB, patch) 2010-10-01 19:05 UTC, Michał Górny	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Paolo Pedroni 2010-10-01 13:48:29 UTC

The init script for net-p2p/deluge-1.3.0 has a few bashism that do not allow it to run if the user is using dash instead of bash to parse init scripts. The attached patch fixes this problem.

Comment 1 Paolo Pedroni 2010-10-01 13:49:48 UTC

Created attachment 249177 [details, diff]
Patch to fix bashisms in init script

Comment 2 Michał Górny archtester

2010-10-01 19:04:44 UTC

Thanks for the patch.

Comment 3 Michał Górny archtester

2010-10-01 19:05:41 UTC

Created attachment 249200 [details, diff]
Simplify user & group mangling

And a second patch from me, removes a lot of redundancy from the init.d script.

I should add that we shouldn't rely on getent there anyway; it is unportable.

Comment 4 Raúl Porcel (RETIRED) gentoo-dev

2010-10-02 16:54:17 UTC

Fixed, thanks