Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33924 - Patch for Gaim to use mozilla's nss/nspr libraries if installed
Summary: Patch for Gaim to use mozilla's nss/nspr libraries if installed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gaim Bugs Crew
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-20 04:44 UTC by Eric Hustvedt
Modified: 2003-11-21 14:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
gaim-0.72.ebuild.diff (gaim-0.72.ebuild.diff,2.16 KB, patch)
2003-11-20 04:46 UTC, Eric Hustvedt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Hustvedt 2003-11-20 04:44:23 UTC
In the interests of minimizing the redundant libraries on my system, I created this patch to the gaim-0.72-r1.ebuild. It checks for the presence of net-www/mozilla, and will use its nss and nspr, rather than installing the separate versions.
Comment 1 Eric Hustvedt 2003-11-20 04:46:42 UTC
Created attachment 20985 [details, diff]
gaim-0.72.ebuild.diff

This patch implements some rather simple modifications to the ebuild. They use
the abilities of portage to selectively include or exclude dependencies.
Comment 2 Don Seiler (RETIRED) gentoo-dev 2003-11-20 06:07:10 UTC
Fantastic idea.  I'll test it out and bounce it off of lostlogic.
Comment 3 Don Seiler (RETIRED) gentoo-dev 2003-11-20 19:20:22 UTC
Working this in.

FYI ebuilds must have actual tabs for indentation, no spaces.

Thanks.
Comment 4 Don Seiler (RETIRED) gentoo-dev 2003-11-20 19:44:28 UTC
Switched your logic in the DEPENDS clause.  The way it was listed, if neither mozilla nor nss were installed, gaim would depend on mozilla.  lostlogic and I agree that it should just depend on nss.
Comment 5 Don Seiler (RETIRED) gentoo-dev 2003-11-20 20:12:15 UTC
gaim-0.72-r2 is now in portage.

Thanks.
Comment 6 Eric Hustvedt 2003-11-20 20:15:31 UTC
When I tried it that way in my testing, portage kept wanting to install nss on top of my mozilla install. If it still needs nss to be installed, on top of mozilla, then the patch kind of loses it raison d'etre.

Re: tabs.
In the future I'll make sure to use tabs in my ebuilds. Thanks for the tip.
Comment 7 Don Seiler (RETIRED) gentoo-dev 2003-11-20 20:20:33 UTC
Eh I'll reopen this then.

Well we definitely want to choose nss over mozilla if neither is installed, so we definitely didn't lose anything yet.  Just need to get the logic down for seeing mozilla.
Comment 8 Eric Hustvedt 2003-11-20 20:45:09 UTC
Hmm... I had an earlier idea to make dev-libs/nss and net-www/mozilla provide a virtual/nss, which the gaim ebuild (as well as any other ebuild that needs nss) could depend upon.
When I suggested it in the past, the mozilla maintainer said that they were looking into rewrite the mozilla ebuild to depend upon dev-libs/nss, sort of like the RPM way of doing things. My research showed that the RPM spec file builds all the nss/nspr libraries as part of building the entire mozilla app. It's only after the build is done that the individual libraries are shoved into the separate RPMs (ie. it's a king-size kludge).
Comment 9 Don Seiler (RETIRED) gentoo-dev 2003-11-21 06:39:10 UTC
Hmm virtual/nss is a neat idea and would certainly take care of these issues.  Otherwise we were looking at some changes for Bug 30071 but those turned out to be more than we bargained for so it more or less is a dead issue right now.

I'll ask the mozilla devs about this.
Comment 10 Eric Hustvedt 2003-11-21 12:15:27 UTC
The other, simpler, way to handle things would involve using the mozilla USE flag to select net-www/mozilla over dev-libs/nss.
Comment 11 Don Seiler (RETIRED) gentoo-dev 2003-11-21 12:32:56 UTC
Yes the mozilla USE flag is a great idea.  Working this up now.
Comment 12 Don Seiler (RETIRED) gentoo-dev 2003-11-21 14:43:18 UTC
This is in CVS and works fine.  Installed gaim both ways.