Bug 338997 – Stabilize =media-video/dvdrip-0.98.11

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Samuli Suominen (RETIRED) 2010-09-28 06:52:26 UTC]

should be good

[Comment 1 Samuli Suominen (RETIRED) 2010-09-28 16:42:26 UTC]

ppc64 stable for:

dev-perl/Event-ExecFlow-0.64
media-video/dvdrip-0.98.11

(compile tested only, not much changed since current regarding app itself)

[Comment 2 David Abbott (RETIRED) 2010-09-29 19:53:23 UTC]

x86 all good but I still get bug 333739
Timestamp of tree: Wed, 29 Sep 2010 17:30:01 +0000

=dev-perl/Event-ExecFlow-0.64
=media-video/dvdrip-0.98.11



 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/dvdrip-splitpipe
 * /usr/bin/dvdrip-progress


>>> Installing (1 of 1) media-video/dvdrip-0.98.11

[Comment 3 Markos Chandras (RETIRED) 2010-09-30 11:28:19 UTC]

=dev-perl/Event-ExecFlow-0.64
=media-video/dvdrip-0.98.11

On amd64 too

CCing Samuli since he did the fix on dvdrip according to Changelogs

[Comment 4 Samuli Suominen (RETIRED) 2010-09-30 12:01:11 UTC]

I'm seeing:

cd src && make
make[1]: Entering directory `/var/tmp/portage/media-video/dvdrip-0.98.11/work/dvdrip-0.98.11/src'
cc -Wl,--hash-style=gnu -Wl,-O1 -Wl,--as-needed -fstack-protector -march=core2 -msse4.1 -O2 -pipe -o dvdrip-splitpipe dvdrip-splitpipe.c && mv dvdrip-splitpipe ../bin
cc -Wl,--hash-style=gnu -Wl,-O1 -Wl,--as-needed -fstack-protector -march=core2 -msse4.1 -O2 -pipe -o dvdrip-progress dvdrip-progress.c && mv dvdrip-progress ../bin

And no LDFLAGS warning. The src_prepare() is fixing it for me.

[Comment 5 Torsten Veller (RETIRED) 2010-09-30 12:15:10 UTC]

`perl -V:ldflags` please.
Also DOCS should be replace by mydoc="Credits"

[Comment 6 Markos Chandras (RETIRED) 2010-09-30 12:38:16 UTC]

(gentoo-stable) Mystical ~ # perl -V:ldflags                                                                                     
ldflags=' -L/usr/local/lib64';

That is strange...

[Comment 7 Samuli Suominen (RETIRED) 2010-09-30 12:45:38 UTC]

The dvdrip "${S}" has dummy ./configure script that has:

perl Makefile.PL

would that be messing things up?

[Comment 8 Samuli Suominen (RETIRED) 2010-09-30 12:46:39 UTC]

Created attachment 249071 [details, diff]
Try #1 ?

[Comment 9 Torsten Veller (RETIRED) 2010-09-30 13:20:17 UTC]

-       sed -i -e 's:$(CC):$(CC) $(LDFLAGS):' src/Makefile || die
+       sed -i -e 's:$(CC):$(CC) $(OTHERLDFLAGS):' src/Makefile || die

is probably the easiest way to fix it. emake OTHERLDFLAGS="${LDFLAGS}" is used in perl-module_src_compile.

configure isn't used.

[Comment 10 Markos Chandras (RETIRED) 2010-10-03 17:12:35 UTC]

I applied the patch and marked it stable for amd64

[Comment 11 Markus Meier 2010-10-05 19:46:10 UTC]

x86 stable, thanks David

[Comment 12 Raúl Porcel (RETIRED) 2010-10-12 15:54:26 UTC]

sparc stable

[Comment 13 Samuli Suominen (RETIRED) 2010-11-06 11:49:48 UTC]

dropped