Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33848 - Error in patch to cisco-vpnclient
Summary: Error in patch to cisco-vpnclient
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-19 11:41 UTC by Dominik Stadler (RETIRED)
Modified: 2003-11-19 12:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Stadler (RETIRED) gentoo-dev 2003-11-19 11:41:25 UTC
The Patch for the cisco-vpnclient (ebuild: cisco-vpnclient-3des) has the
following patch for Kernel 2.6.x:

--- interceptor.c.orig  2003-10-27 14:59:18.474879600 -0500
+++ interceptor.c       2003-10-27 14:59:05.186899680 -0500
@@ -322,12 +322,12 @@

     dev_add_pack(&dummy_pt);
     /* this should be the original IP packet handler */
-    default_pt = dummy_pt.next;
+    default_pt = list_entry(dummy_pt.list.next, struct packet_type, list);
     /* there may be more than one other packet handler in our bucket,
      * so look through all the buckets */
     while (default_pt != NULL && default_pt->type != htons(ETH_P_IP))
     {
-        default_pt = default_pt->next;
+        default_pt = list_entry(dummy_pt.list.next, struct packet_type, list);
     }
     if (!default_pt)
     {


shouldn't the second change be (i.e. don't change default_pt to dummy_pt):

-        default_pt = default_pt->next;
+        default_pt = list_entry(default_pt.list.next, struct packet_type, list);

I have not yet installed this ebuild, therefore I have no way of finding out
more, sorry, but I thought this might be a bug that should get fixed. Please
resolve WONTFIX if this change is intended.

Reproducible: Always
Steps to Reproduce:
Comment 1 SpanKY gentoo-dev 2003-11-19 12:18:50 UTC
nope, you're right ... my mistake ...