338469 – devmanual: 'trivial' src_install() lacks a lot of '|| die' statements

Bug 338469 - devmanual: 'trivial' src_install() lacks a lot of '|| die' statements

Summary: devmanual: 'trivial' src_install() lacks a lot of '|| die' statements

Status:	RESOLVED FIXED

Alias:	None

Product:	Documentation
Classification:	Unclassified
Component:	Devmanual (show other bugs)
Hardware:	All Linux

Importance:	High major (vote)
Assignee:	Gentoo Quality Assurance Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-09-23 18:11 UTC by Michał Górny
Modified:	2010-09-23 20:02 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to fix the issue (0001-Add-missing-die-s-to-do-and-new-calls-in-example-src.patch,2.62 KB, patch) 2010-09-23 18:14 UTC, Michał Górny	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2010-09-23 18:11:27 UTC

http://devmanual.gentoo.org/ebuild-writing/functions/src_install/index.html#trivial-installs

The 'trivial install' code lacks a lot of obligatory '|| die' statements. I think the issue is quite important as we often tend to refer to devmanual to newbies, and it's really a bad idea to refer to a docs having such serious QA issues.

Comment 1 Michał Górny archtester

2010-09-23 18:14:11 UTC

Created attachment 248454 [details, diff]
Patch to fix the issue

Comment 2 Agostino Sarubbo gentoo-dev

2010-09-23 18:29:37 UTC

Michal,

I very much agree with the change that you make, but can not find that there are other functions in devmanual with " || die " missing?

Comment 3 Markos Chandras (RETIRED) gentoo-dev

2010-09-23 20:02:00 UTC

Fixed

Thanks Michal