Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 338397 - kde4-meta.eclass tries to unpack non-existing files
Summary: kde4-meta.eclass tries to unpack non-existing files
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 386105 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-23 00:16 UTC by SpanKY
Modified: 2011-10-16 11:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2010-09-23 00:16:39 UTC
none of the `tar` commands do error checking in kde4-meta.eclass.  this is a pita on my dev system where i have manifest behavior changed (to make ebuild development a hell of a lot easier).  so when emerging kde packages with partial kde tarballs, i get a variety of errors at a later point in time instead of at the `tar` step.

for example:
 - missing files to patch against
 - missing dirs to change into
 - missing files for compilation

the last one in particular is a pain because i get weird build errors that no one else sees.  like konq that mostly unpacked except for a doc file or two, and so building the docs fails.

who knows, maybe some packages even install correctly in the face of missing files because the build skips things when the local files dont exist ...

simple fix: add a '|| die' every time `tar` or some decompressor is run.
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2010-12-14 21:35:48 UTC
The fix was actually only editing one line (I checked all kde4-* eclasses).

Done in overlay, will move to the tree after some testing.
Comment 2 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2010-12-16 14:48:27 UTC
Reverted, it broke extracting of kdebase-runtime-4.5.85 (dunno about other breakages)
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2010-12-16 15:53:00 UTC
OK, I pushed a commit instead that makes at least the warnings/errors visible. Now we can search for the bad cases...
Comment 4 Theo Chatzimichos (RETIRED) archtester gentoo-dev Security 2010-12-29 16:39:30 UTC
In tree
Comment 5 Maciej Mrozowski gentoo-dev 2011-01-12 21:18:44 UTC
Well, silencing it doesn't really constitute as fixed, reopening.
Maybe there's a way to get rid of KMEXTRA_NONFATAL.
Comment 6 Andreas K. Hüttel archtester gentoo-dev 2011-02-25 22:32:55 UTC
The errors are now not ignored anymore but printed out. For devs, they generate an ewarn. 

Now what remains is to fix the file lists...

(It probably makes no sense to start fixing this before the kde git migration is completed. Right now we dont really have an idea yet how the new tarballs will look like.)
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2011-04-17 20:26:05 UTC
No regression compared to 4.4, so does not block stabilization
Comment 8 Andreas K. Hüttel archtester gentoo-dev 2011-05-14 22:06:51 UTC
The list of non-existing files for kde-4.6.3:

kdeaccessibility-4.6.3/AUTHORS
kdeaccessibility-4.6.3/ChangeLog
kdeaccessibility-4.6.3/ConfigureChecks.cmake
kdeaccessibility-4.6.3/INSTALL
kdeaccessibility-4.6.3/NEWS
kdeaccessibility-4.6.3/README
kdeaccessibility-4.6.3/config.h.cmake
kdeadmin-4.6.3/ChangeLog
kdeadmin-4.6.3/ConfigureChecks.cmake
kdeadmin-4.6.3/INSTALL
kdeadmin-4.6.3/NEWS
kdeadmin-4.6.3/cmake
kdeadmin-4.6.3/config.h.cmake
kdeartwork-4.6.3/AUTHORS
kdeartwork-4.6.3/ChangeLog
kdeartwork-4.6.3/ConfigureChecks.cmake
kdeartwork-4.6.3/INSTALL
kdeartwork-4.6.3/NEWS
kdeartwork-4.6.3/config.h.cmake
kdebase-4.6.3/AUTHORS
kdebase-4.6.3/ChangeLog
kdebase-4.6.3/ConfigureChecks.cmake
kdebase-4.6.3/INSTALL
kdebase-4.6.3/NEWS
kdebase-4.6.3/cmake
kdebase-4.6.3/config.h.cmake
kdebase-4.6.3/doc/konsole
kdebase-4.6.3/konqueror/client
kdebase-runtime-4.6.3/AUTHORS
kdebase-runtime-4.6.3/ChangeLog
kdebase-runtime-4.6.3/ConfigureChecks.cmake
kdebase-runtime-4.6.3/INSTALL
kdebase-runtime-4.6.3/NEWS
kdebase-runtime-4.6.3/README
kdebase-runtime-4.6.3/cmake/CMakeLists.txt
kdebase-runtime-4.6.3/cmake/modules
kdebase-runtime-4.6.3/config-runtime.h.cmake
kdebase-runtime-4.6.3/config.h.cmake
kdebase-runtime-4.6.3/doc/CMakeLists.txt
kdebase-workspace-4.6.3/AUTHORS
kdebase-workspace-4.6.3/ChangeLog
kdebase-workspace-4.6.3/ConfigureChecks.cmake
kdebase-workspace-4.6.3/INSTALL
kdebase-workspace-4.6.3/NEWS
kdebase-workspace-4.6.3/cmake/CMakeLists.txt
kdebase-workspace-4.6.3/cmake/modules
kdebase-workspace-4.6.3/config.h.cmake
kdebase-workspace-4.6.3/doc/CMakeLists.txt
kdebase-workspace-4.6.3/doc/plasma
kdebase-workspace-4.6.3/startkde.cmake
kdebindings-4.6.3/ConfigureChecks.cmake
kdebindings-4.6.3/config.h.cmake
kdeedu-4.6.3/AUTHORS
kdeedu-4.6.3/ChangeLog
kdeedu-4.6.3/ConfigureChecks.cmake
kdeedu-4.6.3/NEWS
kdeedu-4.6.3/cmake/CMakeLists.txt
kdeedu-4.6.3/cmake/modules
kdeedu-4.6.3/config.h.cmake
kdegames-4.6.3/ChangeLog
kdegames-4.6.3/ConfigureChecks.cmake
kdegames-4.6.3/NEWS
kdegames-4.6.3/cmake/CMakeLists.txt
kdegames-4.6.3/cmake/modules
kdegames-4.6.3/config.h.cmake
kdegames-4.6.3/libkdegames
kdegraphics-4.6.3/ConfigureChecks.cmake
kdegraphics-4.6.3/NEWS
kdegraphics-4.6.3/config.h.cmake
kdegraphics-4.6.3/doc/CMakeLists.txt
kdegraphics-4.6.3/doc/gwenview
kdegraphics-4.6.3/doc/kamera
kdegraphics-4.6.3/doc/kgamma
kdegraphics-4.6.3/doc/kolourpaint
kdegraphics-4.6.3/doc/kruler
kdegraphics-4.6.3/doc/ksnapshot
kdemultimedia-4.6.3/ChangeLog
kdemultimedia-4.6.3/NEWS
kdemultimedia-4.6.3/doc/CMakeLists.txt
kdemultimedia-4.6.3/doc/kscd
kdenetwork-4.6.3/AUTHORS
kdenetwork-4.6.3/ChangeLog
kdenetwork-4.6.3/ConfigureChecks.cmake
kdenetwork-4.6.3/NEWS
kdenetwork-4.6.3/config.h.cmake
kdesdk-4.6.3/AUTHORS
kdesdk-4.6.3/ChangeLog
kdesdk-4.6.3/ConfigureChecks.cmake
kdesdk-4.6.3/INSTALL
kdesdk-4.6.3/NEWS
kdesdk-4.6.3/config.h.cmake
kdesdk-4.6.3/doc/CMakeLists.txt
kdetoys-4.6.3/ChangeLog
kdetoys-4.6.3/ConfigureChecks.cmake
kdetoys-4.6.3/INSTALL
kdetoys-4.6.3/NEWS
kdetoys-4.6.3/cmake
kdetoys-4.6.3/config.h.cmake
kdeutils-4.6.3/ChangeLog
kdeutils-4.6.3/ConfigureChecks.cmake
kdeutils-4.6.3/NEWS
kdeutils-4.6.3/config.h.cmake
kdeutils-4.6.3/doc/CMakeLists.txt
kdeutils-4.6.3/doc/kremotecontrol
kdewebdev-4.6.3/cmake
kdewebdev-4.6.3/config.h.cmake
Comment 9 Andreas K. Hüttel archtester gentoo-dev 2011-05-14 22:10:39 UTC
Removed some entries in overlay eclass. New list:

kdeaccessibility-4.6.3/ConfigureChecks.cmake
kdeaccessibility-4.6.3/config.h.cmake
kdeadmin-4.6.3/ConfigureChecks.cmake
kdeadmin-4.6.3/cmake
kdeadmin-4.6.3/config.h.cmake
kdeartwork-4.6.3/ConfigureChecks.cmake
kdeartwork-4.6.3/config.h.cmake
kdebase-4.6.3/ConfigureChecks.cmake
kdebase-4.6.3/cmake
kdebase-4.6.3/config.h.cmake
kdebase-4.6.3/doc/konsole
kdebase-4.6.3/konqueror/client
kdebase-runtime-4.6.3/ConfigureChecks.cmake
kdebase-runtime-4.6.3/cmake/CMakeLists.txt
kdebase-runtime-4.6.3/cmake/modules
kdebase-runtime-4.6.3/config-runtime.h.cmake
kdebase-runtime-4.6.3/config.h.cmake
kdebase-runtime-4.6.3/doc/CMakeLists.txt
kdebase-workspace-4.6.3/ConfigureChecks.cmake
kdebase-workspace-4.6.3/cmake/CMakeLists.txt
kdebase-workspace-4.6.3/cmake/modules
kdebase-workspace-4.6.3/config.h.cmake
kdebase-workspace-4.6.3/doc/CMakeLists.txt
kdebase-workspace-4.6.3/doc/plasma
kdebase-workspace-4.6.3/startkde.cmake
kdebindings-4.6.3/ConfigureChecks.cmake
kdebindings-4.6.3/config.h.cmake
kdeedu-4.6.3/ConfigureChecks.cmake
kdeedu-4.6.3/cmake/CMakeLists.txt
kdeedu-4.6.3/cmake/modules
kdeedu-4.6.3/config.h.cmake
kdegames-4.6.3/ConfigureChecks.cmake
kdegames-4.6.3/cmake/CMakeLists.txt
kdegames-4.6.3/cmake/modules
kdegames-4.6.3/config.h.cmake
kdegames-4.6.3/libkdegames
kdegraphics-4.6.3/ConfigureChecks.cmake
kdegraphics-4.6.3/config.h.cmake
kdegraphics-4.6.3/doc/CMakeLists.txt
kdegraphics-4.6.3/doc/gwenview
kdegraphics-4.6.3/doc/kamera
kdegraphics-4.6.3/doc/kgamma
kdegraphics-4.6.3/doc/kolourpaint
kdegraphics-4.6.3/doc/kruler
kdegraphics-4.6.3/doc/ksnapshot
kdemultimedia-4.6.3/doc/CMakeLists.txt
kdemultimedia-4.6.3/doc/kscd
kdenetwork-4.6.3/ConfigureChecks.cmake
kdenetwork-4.6.3/config.h.cmake
kdesdk-4.6.3/ConfigureChecks.cmake
kdesdk-4.6.3/config.h.cmake
kdesdk-4.6.3/doc/CMakeLists.txt
kdetoys-4.6.3/ConfigureChecks.cmake
kdetoys-4.6.3/cmake
kdetoys-4.6.3/config.h.cmake
kdeutils-4.6.3/ConfigureChecks.cmake
kdeutils-4.6.3/config.h.cmake
kdeutils-4.6.3/doc/CMakeLists.txt
kdeutils-4.6.3/doc/kremotecontrol
kdewebdev-4.6.3/cmake
kdewebdev-4.6.3/config.h.cmake
Comment 10 Andreas K. Hüttel archtester gentoo-dev 2011-09-22 20:23:04 UTC
(In reply to comment #0)
> none of the `tar` commands do error checking in kde4-meta.eclass.  this is a
> pita on my dev system where i have manifest behavior changed (to make ebuild
> development a hell of a lot easier).  so when emerging kde packages with
> partial kde tarballs, i get a variety of errors at a later point in time
> instead of at the `tar` step.

Well then just dont do that. Anyway, since KDE tarballs are getting more fine-grained every day, this is probably obsolete.

(In reply to comment #6)
> The errors are now not ignored anymore but printed out. For devs, they generate
> an ewarn. 
> 
> Now what remains is to fix the file lists...
> 
> (It probably makes no sense to start fixing this before the kde git migration
> is completed. Right now we dont really have an idea yet how the new tarballs
> will look like.)

... and KDE will never be stable enough to really provide a concise list. 

Only possible concolusion: begone ancient bugreport!
Comment 11 Andreas K. Hüttel archtester gentoo-dev 2011-10-16 11:12:23 UTC
*** Bug 386105 has been marked as a duplicate of this bug. ***