Bug 338377 – fakegem not fill dependency field in gemspec and broke down gem_plugin

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Dmitriy Bogun 2010-09-22 19:21:57 UTC]

I have installed mongrel_cluster and was unable to use it because of very strange error.

$ mongrel_rails cluster::start
ERROR RUNNING 'cluster::start': Plugin /cluster::start does not exist in category /commands
Use help command to get help

After long time looking whats going on, I have foud the source of the problem. gem_pugin use dependency declared into gemspec to load nessesary packages. But ruby-fakegem.eclass completely recreate gemspec and not set dependency at all...

Why we need to do so ugly thing? Why we can't change required fiends with sed?

One more thing - gem_plugin have one more. Webarchive is only place that steel keep info about it - http://web.archive.org/web/20080624225921/mongrel.rubyforge.org/ticket/22

Reproducible: Always

[Comment 1 Dmitriy Bogun 2010-09-22 19:28:12 UTC]

Created attachment 248383 [details, diff]
patch for gem_plugin

[Comment 2 Michał Górny 2010-09-22 20:46:04 UTC]

Please rewrite the patch, keeping upstream whitespace and indentation conventions.

[Comment 3 Dmitriy Bogun 2010-09-23 00:18:53 UTC]

Created attachment 248401 [details, diff]
patch for gem_plugin(updated)

[Comment 4 Michał Górny 2010-09-23 07:50:40 UTC]

(In reply to comment #3)
> Created an attachment (id=248401) [details]

I still see different indentation there.

[Comment 5 Dmitriy Bogun 2010-09-23 08:56:56 UTC]

I am not see it.
If you need patch - you can fix it yourself, there is only 27 lines and only ~10 significant.

[Comment 6 Dmitriy Bogun 2010-09-23 08:59:43 UTC]

The main problem not in gem_plugin. It is in ruby-fakegem.eclass see bug description.

[Comment 7 Michał Górny 2010-09-23 09:16:26 UTC]

(In reply to comment #5)
> I am not see it.

Then click on your patch and see it for yourself.

[Comment 8 Dmitriy Bogun 2010-09-23 09:34:16 UTC]

Forgot about patch - what about ruby-fakegem.eclass?

[Comment 9 Hans de Graaff 2010-09-27 19:18:04 UTC]

Dmitriy, if you have multiple issues then please file different bugs for them, which makes tracking these issues a lot easier.

Yes, it would be nice to have better dependency information in the gemspec files, but unfortunately it is not such an easy problem. There is bug 313279 but recent bundler version have also moved away from using this information, so fixing this is a low-priority item for us. Patches welcome.

[Comment 10 Hans de Graaff 2011-07-21 06:23:41 UTC]

This has been fixed since december 2010. We now try to install the original gemspec when possible.