Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 338327 - app-portage/deltup segfaults creating delta between qt-everywhere-opensource-src-4.6.3.tar.gz and qt-everywhere-opensource-src-4.7.0.tar.gz
Summary: app-portage/deltup segfaults creating delta between qt-everywhere-opensource-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 06:05 UTC by Artem S. Tashkinov
Modified: 2011-12-07 20:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Artem S. Tashkinov 2010-09-22 06:05:20 UTC
deltup -m -b 9 -j -v qt-everywhere-opensource-src-4.6.3.tar.gz qt-everywhere-opensource-src-4.7.0.tar.gz /tmp/qt-4.6.3-4.7.0.delta
Looking at package contents
Making package delta
Ensuring MD5sum will be correct
here 9
Output package to: /tmp/qt-4.6.3-4.7.0.delta
cleaning up
Segmentation fault

Reproducible: Always




gdb deltup
GNU gdb (GDB) (7.1)
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /usr/local/bin/deltup...done.
(gdb) run -m -b 9 -j -v qt-everywhere-opensource-src-4.6.3.tar.gz qt-everywhere-opensource-src-4.7.0.tar.gz /tmp/qt-4.6.3-4.7.0.delta
Starting program: /usr/local/bin/deltup -m -b 9 -j -v qt-everywhere-opensource-src-4.6.3.tar.gz qt-everywhere-opensource-src-4.7.0.tar.gz /tmp/qt-4.6.3-4.7.0.delta
[Thread debugging using libthread_db enabled]
Detaching after fork from child process 3669.
Looking at package contents
Detaching after fork from child process 3670.
Detaching after fork from child process 3672.
Making package delta
Detaching after fork from child process 3675.
Detaching after fork from child process 3715.
Ensuring MD5sum will be correct
here 9
Detaching after fork from child process 3716.
Detaching after fork from child process 3726.
Detaching after fork from child process 3727.
Detaching after fork from child process 3729.
Detaching after fork from child process 3730.
Output package to: /tmp/qt-4.6.3-4.7.0.delta

Program received signal SIGSEGV, Segmentation fault.
0xb7ce5fed in fseek () from /lib/libc.so.6
Missing separate debuginfos, use: debuginfo-install bzip2-libs-1.0.5-6.fc12.i686 glibc-2.12-3.i686 keyutils-libs-1.2-6.fc12.i686 krb5-libs-1.7.1-13.fc13.i686 libcom_err-1.41.10-7.fc13.i686 libgcc-4.4.4-10.fc13.i686 libselinux-2.0.94-2.fc13.i686 libstdc++-4.4.4-10.fc13.i686 openssl-1.0.0a-1.fc13.i686 zlib-1.2.3-23.fc12.i686

(gdb) bt
#0  0xb7ce5fed in fseek () from /lib/libc.so.6
#1  0x0804a3cb in getLenOfFile (fname="/tmp/.Ls6F4I/000000") at file.cpp:37
#2  0x0804f7a2 in createDelta (oldfile="qt-everywhere-opensource-src-4.6.3.tar.gz", newfile="qt-everywhere-opensource-src-4.7.0.tar.gz", patchfname=
    "/tmp/qt-4.6.3-4.7.0.delta") at deltup.cpp:303
#3  0x08054069 in main (argc=9, argv=0xbffff614) at deltup.cpp:626
Comment 1 Zac Medico gentoo-dev 2010-11-24 20:24:19 UTC
The segfault in fseek seems odd. Is there a wrong way to call fseek?

Anyway, if it is a deltup bug, there's a 0.4.5 version bump available to try:

  http://www.deltup.org/download.php?list.2
Comment 2 Artem S. Tashkinov 2010-11-24 20:29:40 UTC
(In reply to comment #1)
> The segfault in fseek seems odd. Is there a wrong way to call fseek?
> 
> Anyway, if it is a deltup bug, there's a 0.4.5 version bump available to try:
> 
>   http://www.deltup.org/download.php?list.2
> 

The diff between the old and the new versions only adds missing headers for successful compilation using GCC >= 4.4.0. So the bug couldn't have gone.
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2011-12-07 07:38:26 UTC
> The diff between the old and the new versions only adds missing headers for
> successful compilation using GCC >= 4.4.0. So the bug couldn't have gone.

Portage has "ancient" bdelta package (upstream released 0.2.3 recently).

@tools-portage:
I use/tune bdelta time to time (mostly at work).
Are you OK if i'll add myself as a maintainer of dev-util/bdelta and app-portage/deltup?
Comment 4 Paul Varner (RETIRED) gentoo-dev 2011-12-07 15:31:59 UTC
(In reply to comment #3)
> Are you OK if i'll add myself as a maintainer of dev-util/bdelta and
> app-portage/deltup?

Yes, go for it!
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2011-12-07 19:20:59 UTC
Bumped bdelta (pulled a bit of patches in the queue)

> *bdelta-0.2.3 (07 Dec 2011)
> 
>   07 Dec 2011; Sergei Trofimovich <slyfox@gentoo.org> +bdelta-0.2.3.ebuild,
>   +files/bdelta-0.2.3-Makefile-add-make-clean-target.patch,
>   +files/bdelta-0.2.3-Makefile-create-LIBDIR-as-well.patch, +files/bdelta-0.2.3-
>   Makefile-fix-paralell-building-bdelta-depends-on-it-.patch,
>   +files/bdelta-0.2.3-bdelta.h-make-header-C-compatible.patch,
>   +files/bdelta-0.2.3-fix-stack-smash.patch,
>   +files/bdelta-0.2.3-libbdelta-rename-NDEBUG-to-DO_STATS_DEBUG.patch, +files/bd
>   elta-0.2.3-makefile-restect-user-s-LDFLAGS-CXXFLAGS-and-other-v.patch,
>   metadata.xml:
>   Version bump. Fixes bug #338327 by Artem S. Tashkinov. Added myself to
>   maintainers.

The patch fixing this exact issue is 'files/bdelta-0.2.3-fix-stack-smash.patch'.

I've reproduced in on qt 4.6.3 to 4.7.4 diff +bdelta-0.2.3 and made sure patch helps (upstreamed).

Thanks Artem!