Bug 338296 – New ebuild: app-office/qgoogletranslator-1.2.1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Stanislav Cymbalov 2010-09-21 19:26:42 UTC]

Qt4 interface for google translate.

Reproducible: Always

[Comment 1 Stanislav Cymbalov 2010-09-21 19:28:19 UTC]

Created attachment 248291 [details]
An ebuild for package

[Comment 2 Agostino Sarubbo 2010-09-22 12:59:57 UTC]

E2160 qgoogletranslator # repoman full qgoogletranslator-1.0.0.ebuild                                                     

RepoMan scours the neighborhood...                                                                                            
  metadata.missing              1
   app-office/qgoogletranslator/metadata.xml
  EAPI.definition               1
   app-office/qgoogletranslator/qgoogletranslator-1.0.0.ebuild: EAPI defined after inherit on line: 7
  ebuild.allmasked              1
   app-office/qgoogletranslator
  ebuild.minorsyn               1
   app-office/qgoogletranslator/qgoogletranslator-1.0.0.ebuild: Unquoted Variable on line: 26


Please considered:
EAPI.definition
ebuild.minorsyn


Thanks
ago

[Comment 3 Michał Górny 2010-09-22 17:51:25 UTC]

Thank you for your ebuild. However, it shows many QA violations; we'd appreciate if you could fix them, using our advices and appropriate documentation [1].

Here are the issues that I see now:
- please declare EAPI before inherits,
- don't use EAPI higher than required by the features you're using (in this case, EAPI=2 is sufficient) [2],
- you mentioned qt-gui:4 in your DEPEND twice,
- src_prepare() is being run inside ${S}, so it's not necessary to pass that path to find; if it would, you'd need to quote it as it may contain spaces,
- it's better to use 'find ... -exec rm -rf {} +' than escaped backslash syntax -- it is faster, cleaner; in any case, it is unnecessary to quote {},
- you shouldn't redirect stderr when calling find; if 'rm -rf' prints anything, then it's worth noticing,
- dodoc, doins and similar do* functions need a '|| die' statement, e.g. 'dodoc WISHLIST.txt || die'.

[1] http://devmanual.gentoo.org/
[2] http://devmanual.gentoo.org/ebuild-writing/eapi/index.html#eapi="3"

[Comment 4 Stanislav Cymbalov 2010-09-25 23:51:41 UTC]

Created attachment 248645 [details]
Fixed ebuild

[Comment 5 Michał Górny 2010-09-26 08:08:29 UTC]

Now that your ebuild is clean:

Hello, The Gentoo Team would like to firstly thank you for your ebuild 
submission. We also apologize for not being able to accommodate you in a timely
manner. There are simply too many new packages.

Allow me to use this opportunity to introduce you to Gentoo Sunrise. The 
sunrise overlay[1] is a overlay for Gentoo which we allow trusted users to 
commit to and all users can have ebuilds reviewed by Gentoo devs for entry 
into the overlay. So, the sunrise team is suggesting that you look into this 
and submit your ebuild to the overlay where even *you* can commit to. =)

Thanks,
On behalf of the Gentoo Sunrise Team,
Michał.

[1]: http://www.gentoo.org/proj/en/sunrise/
[2]: http://overlays.gentoo.org/proj/sunrise/wiki/SunriseFaq

[Comment 6 Stanislav Cymbalov 2010-11-21 15:36:49 UTC]

Created attachment 255025 [details]
new version

[Comment 7 Stanislav Cymbalov 2010-11-21 15:41:09 UTC]

Created attachment 255027 [details]
forces to use external libqxt

[Comment 8 Agostino Sarubbo 2010-11-21 18:47:35 UTC]

I tested it on my x86 machine, you could also change by putting x86 keyword

[Comment 9 Stanislav Cymbalov 2010-11-21 21:05:35 UTC]

Created attachment 255069 [details]
added ~x86 keyword

[Comment 10 Markos Chandras (RETIRED) 2010-12-04 11:27:05 UTC]

Why is this bug still open?? The ebuild is already on tree