Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 337978 - sci-libs/clapack-3.2.1-r3 ebuild is completely false
Summary: sci-libs/clapack-3.2.1-r3 ebuild is completely false
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-18 22:08 UTC by Samuli Suominen (RETIRED)
Modified: 2010-09-18 22:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2010-09-18 22:08:10 UTC
The \ should be dropped from:

mycmakeargs=( \

And IUSE is missing both "test" and "static-libs"
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2010-09-18 22:08:57 UTC
Futhermore bash assigment doesn't need quoting:

S="${WORKDIR}/${P}-CMAKE"

should be

S=${WORKDIR}/${P}-CMAKE

Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2010-09-18 22:12:06 UTC
Futhermore I'm not convinced the cmake-utils_use_enable's are working at all, given the flag is -DBUILD_TESTING instead of -DENABLE_TESTS
Not sure on the static-libs one either, unless it's a cmake internal thing, certainly the provided build system doesn't export one 
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2010-09-18 22:45:08 UTC
> The \ should be dropped from:
> mycmakeargs=( \
Fixed.

> And IUSE is missing both "test" and "static-libs"
Done for "test".

> Futhermore bash assigment doesn't need quoting:
> S=${WORKDIR}/${P}-CMAKE
Done

> Futhermore I'm not convinced the cmake-utils_use_enable's are working at all,
> given the flag is -DBUILD_TESTING instead of -DENABLE_TESTS
That definitely is correct since I wrote the IF's myself. Maybe just a bit too complicated.

> Not sure on the static-libs one either, unless it's a cmake internal thing,
> certainly the provided build system doesn't export one 
That's not correct, since there is indeed no static lib target. Removed.