Bug 33777 – Unnecessary ARCH check in net-mail/ximian-connector-1.2.2_p1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Sven Blumenstein (RETIRED) 2003-11-18 12:20:10 UTC]

net-mail/ximian-connector-1.2.2_p1 does check for a supported ARCH and dies if the current ARCH is unsupported:

!!! ERROR: net-mail/ximian-connector-1.2.2_p1 failed.
!!! Function , Line 22, Exitcode 1
!!! Unsupported ARCH: 

The part of the ebuild:

if [ `use ppc` ]; then 
    XIMIAN_DIST="yellowdog-22-ppc"
    XIMIAN_ARCH="ppc"
elif [ `use x86` ]; then 
    XIMIAN_DIST="redhat-73-i386"
    XIMIAN_ARCH="i386"
else
    die "Unsupported ARCH: ${ARCH}"
fi


This check is unnecessary as the KEYWORDS already take care of filtering out unsupported ARCH's:

KEYWORDS="x86 ~ppc -sparc -alpha -mips"

Main problem is that this 'die' causes some tools to break, like for example esearch/eupdatedb:

root@darwin bazik # eupdatedb 
 * indexing: 1514 ebuilds to go
aux_get(): (0) Error in net-mail/ximian-connector-1.2.2_p1 ebuild.
               Check for syntax error or corruption in the ebuild. (--debug)


And repoman doesnt like the ebuild either. My suggested change attached as patch below.

[Comment 1 Sven Blumenstein (RETIRED) 2003-11-18 12:24:25 UTC]

Created attachment 20923 [details, diff]
Said patch. Yes, its small I know ;)

[Comment 2 Alastair Tse (RETIRED) 2003-11-20 03:28:24 UTC]

ok, should be fixed in the next couple of minutes