Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 337419 - net-mail/fdm fails parallel make
Summary: net-mail/fdm fails parallel make
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 06:51 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2010-09-17 22:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (fdm-1.6-r1:20100915-010407.log,44.68 KB, text/plain)
2010-09-15 06:51 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-15 06:51:12 UTC
Portage 2.1.9.5 (default/linux/x86/10.0, gcc-4.5.1-asneeded, glibc-2.12.1-r1, 2.6.35.4+ i686)
=================================================================
System uname: Linux-2.6.35.4+-i686-Quad-Core_AMD_Opteron-tm-_Processor_2350-with-gentoo-2.0.1
Timestamp of tree: Mon, 13 Sep 2010 23:00:01 +0000
distcc 3.1 i686-pc-linux-gnu [disabled]
ccache version 2.4 [disabled]
app-shells/bash:     4.1_p7
dev-java/java-config: 2.1.11
dev-lang/python:     2.7, 3.1.2-r4
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.3
sys-apps/sandbox:    2.3-r1
sys-devel/autoconf:  2.13, 2.67
sys-devel/automake:  1.4_p6-r1, 1.5-r1, 1.6.3-r1, 1.7.9-r2, 1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.5.1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.82
virtual/os-headers:  2.6.35 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/openjms/config /usr/lib/tomoyo/conf /usr/share/X11/xkb /usr/share/bufrtables /usr/share/config /usr/share/qpsmtpd/plugins /var/bind /var/lib/hsqldb /var/lib/redmine/config /var/phxd /var/spool/torque /var/vpopmail/etc /var/yp/Makefile"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/portage /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/portage/distfiles"
FEATURES="assume-digests distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms split-log strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.wheel.sk/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j14"
PKGDIR="/var/spool/portage/packages"
PORTAGE_COMPRESS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cache/portage/tree"
SYNC="rsync://yamato.home.flameeyes.eu/gentoo-portage"
USE="acl berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 java5 java6 modules mudflap mysql ncurses nls nostatic nptl nptlonly openmp pam pcre perl postgres pppd python qt3support readline reflection ruby session ssl sysfs tcpd unicode vhosts x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias auth_digest cgi" ELIBC="glibc" KERNEL="linuxlines 1-45
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-15 06:51:33 UTC
Created attachment 247392 [details]
Build log
Comment 2 Michael Weber (RETIRED) gentoo-dev 2010-09-16 14:49:10 UTC
--- /usr/portage/net-mail/fdm/files/fdm-1.6-r1-GNUmakefile.patch        2010-09-12 21:01:25.961000245 +0200
+++ /tmp/x      2010-09-16 16:47:33.554302653 +0200
@@ -1,5 +1,5 @@
---- /tmp/GNUmakefile   2010-09-12 20:52:36.904000246 +0200
-+++ GNUmakefile        2010-09-12 21:00:52.209000216 +0200
+--- /tmp/GNUmakefile   2010-09-16 16:39:16.656504861 +0200
++++ /var/tmp/portage/net-mail/fdm-1.6-r1/work/fdm-1.6/GNUmakefile      2010-09-16 16:47:13.451721307 +0200
 @@ -16,7 +16,7 @@
  CC= gcc
  
@@ -23,7 +23,7 @@
  ifdef COURIER
  CFLAGS+= -DLOOKUP_COURIER
 -LIBS+= -lcourierauth
-+LIBS+= -L/usr/lib64/courier-authlib -lcourierauth
++LIBS+= -L/usr/lib/courier-authlib -lcourierauth
  endif
  
  ifdef PCRE
@@ -36,7 +36,12 @@
  
  depend: $(SRCS)
        $(CC) $(CPPFLAGS) -MM $(SRCS) > .depend
-@@ -115,10 +115,10 @@
+@@ -112,13 +112,15 @@
+ y.tab.c y.tab.h: parse.y
+       $(YACC) $(YFLAGS) $<
+ 
++lex.o: y.tab.h
++
  install:
        $(INSTALLDIR) $(DESTDIR)$(PREFIX)/bin
        $(INSTALLBIN) $(PROG) $(DESTDIR)$(PREFIX)/bin/$(PROG)
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-16 15:00:21 UTC
the $(YACC) rule is wrong, that way it causes two call to bison which will create races... see my blog post for more details:

http://blog.flameeyes.eu/2009/01/31/for-a-parallel-world-case-study-n-7-single-rule-multiple-outputs
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-16 15:10:19 UTC
The rule is still wrong.
Comment 5 Michael Weber (RETIRED) gentoo-dev 2010-09-16 21:24:51 UTC
Pardon, the only file that depends on y.tab.c is lex.c, so 
lex.o: y.tab. should do the trick. and it does in 600+ probes with -j12 on a quadcore w/o any failure.

Ok?!

Comment 6 Diego Elio Pettenò (RETIRED) gentoo-dev 2010-09-16 21:36:46 UTC
It's a race, it might work 10K times and fail one if there is a difference in scheduling.

The fix is actually easy, as the post should have documented:

foo.h foo.c: foo.y
  $(YACC) $(PARAMS)

should become

foo.h: foo.c

foo.c: foo.y
  $(YACC) $(PARAMS)

easy, no? And much safer...