Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 33738 - fireflies-2.06: screensaver: Wicked cool eye candy
Summary: fireflies-2.06: screensaver: Wicked cool eye candy
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Desktop Misc. Team
URL: http://somewhere.fscked.org/fireflies/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-18 02:23 UTC by Ed Catmur
Modified: 2004-01-04 07:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild (fireflies-2.06.ebuild,750 bytes, patch)
2003-11-18 02:26 UTC, Ed Catmur
Details | Diff
Patch to configure to fix backticks bug (fireflies-2.06-configure.patch,411 bytes, patch)
2003-11-18 02:27 UTC, Ed Catmur
Details | Diff
Patch to properly set CFLAGS etc in Make.include (fireflies-2.06-Make.include.in.patch,666 bytes, patch)
2003-11-18 11:06 UTC, Ed Catmur
Details | Diff
Ebuild to use fltk-config (fireflies-2.06.ebuild,1.08 KB, text/plain)
2003-11-18 11:07 UTC, Ed Catmur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Catmur 2003-11-18 02:23:55 UTC
Fireflies is a rather pretty OpenGL screensaver.

It is referenced in the current XScreensaver package (shows up in 
xscreensaver-demo as a greyed out option) so there is no need to edit /etc/X11/app-defaults/XScreenSaver.

The following patch to configure solves a rather strange problem whereby backticks were not being expanded - it appeared to be triggered by a 
nested make inside ebuild, as compiling by hand in a normal environment 
did not exhibit the problem, but launching a bash shell inside the 
ebuild and compiling from there allowed the problem to manifest.

I suggest x11-misc/fireflies. The SDL useflag allows one to manipulate
the view by mouse when launching the screensaver as a standalone program.
Comment 1 Ed Catmur 2003-11-18 02:26:12 UTC
Created attachment 20899 [details, diff]
Ebuild
Comment 2 Ed Catmur 2003-11-18 02:27:01 UTC
Created attachment 20900 [details, diff]
Patch to configure to fix backticks bug
Comment 3 Ed Catmur 2003-11-18 03:34:17 UTC
I understand the bug now: it seems that make will pass to subprocesses only those
make variables which have a corresponding env var in the environment make was
called from.
In this case, the env var in question is CFLAGS, which is unset in my env but set
in /etc/make.conf.
This means that compiling by hand will FAIL if CFLAGS is set; thus the above patch
is justified.

Also, the bug only occurs when compiling Fireflies with SDL support.
Comment 4 Ed Catmur 2003-11-18 11:06:45 UTC
Created attachment 20918 [details, diff]
Patch to properly set CFLAGS etc in Make.include

Use += syntax to handle CFLAGS additions better
Comment 5 Ed Catmur 2003-11-18 11:07:42 UTC
Created attachment 20919 [details]
Ebuild to use fltk-config

Uses fltk-config to locate fltk headers and libs.
Comment 6 Ed Catmur 2003-11-18 11:09:32 UTC
Comment on attachment 20919 [details]
Ebuild to use fltk-config

Uses fltk-config to locate fltk headers and libs
Comment 7 Ian Leitch (RETIRED) gentoo-dev 2004-01-04 07:07:07 UTC
In CVS, Thanks.