Bug 337324 – net-dns/ez-ipupdate fails to build with linux-headers 2.6.35

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2010-09-14 18:15:43 UTC]

Portage 2.1.9.5 (default/linux/x86/10.0, gcc-4.5.1-asneeded, glibc-2.12.1-r1, 2.6.35.4+ i686)
=================================================================
System uname: Linux-2.6.35.4+-i686-Quad-Core_AMD_Opteron-tm-_Processor_2350-with-gentoo-2.0.1
Timestamp of tree: Mon, 13 Sep 2010 23:00:01 +0000
distcc 3.1 i686-pc-linux-gnu [disabled]
ccache version 2.4 [disabled]
app-shells/bash:     4.1_p7
dev-java/java-config: 2.1.11
dev-lang/python:     2.7, 3.1.2-r4
dev-util/ccache:     2.4-r8
dev-util/cmake:      2.8.1-r2
sys-apps/baselayout: 2.0.1
sys-apps/openrc:     0.6.3
sys-apps/sandbox:    2.3-r1
sys-devel/autoconf:  2.13, 2.67
sys-devel/automake:  1.4_p6-r1, 1.5-r1, 1.6.3-r1, 1.7.9-r2, 1.8.5-r4, 1.9.6-r3, 1.10.3, 1.11.1
sys-devel/binutils:  2.20.1-r1
sys-devel/gcc:       4.5.1
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.2.10
sys-devel/make:      3.82
virtual/os-headers:  2.6.35 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /opt/openjms/config /usr/lib/tomoyo/conf /usr/share/X11/xkb /usr/share/bufrtables /usr/share/config /usr/share/qpsmtpd/plugins /var/bind /var/lib/hsqldb /var/lib/redmine/config /var/phxd /var/spool/torque /var/vpopmail/etc /var/yp/Makefile"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/eselect/postgresql /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/portage /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/portage/distfiles"
FEATURES="assume-digests distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms split-log strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.wheel.sk/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j14"
PKGDIR="/var/spool/portage/packages"
PORTAGE_COMPRESS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cache/portage/tree"
SYNC="rsync://yamato.home.flameeyes.eu/gentoo-portage"
USE="acl berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 java5 java6 modules mudflap mysql ncurses nls nostatic nptl nptlonly openmp pam pcre perl postgres pppd python qt3support readline reflection ruby session ssl sysfs tcpd unicode vhosts x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias auth_digest cgi" ELIBC="glibc" KERNEL="linuxlines 1-45

[Comment 1 Diego Elio Pettenò (RETIRED) 2010-09-14 18:15:53 UTC]

Created attachment 247315 [details]
Build log

[Comment 2 Stefan Briesenick (RETIRED) 2010-09-14 21:29:44 UTC]

any hints for me how to fix it?

[Comment 3 Diego Elio Pettenò (RETIRED) 2010-09-14 21:32:15 UTC]

You likely need some extra #include; as for which one, no idea without looking deeper into it.

[Comment 4 Dane Smith (RETIRED) 2011-01-19 17:03:01 UTC]

Masked for removal on 3-21-2011.

[Comment 5 Martin Väth 2011-01-19 20:45:10 UTC]

(In reply to comment #3)
> You likely need some extra #include

Quite the opposite: It is very strange, but it seems that

#include <net/if.h>
#include <linux/if.h>

is not possible in the same file. This looks to me like a bug in
linux-headers-2.6.35, but I am not a kernel hacker...

Anyway, the second include was introduced with my patch for bug 318905
In this patch the first include should be moved in the non-linux section.
I attach a fix.

[Comment 6 Martin Väth 2011-01-19 20:47:57 UTC]

Created attachment 260291 [details, diff]
Patch for the ez-ipupdate-linux.patch of bug 318905

Of course, there are two ways to fix a patch:
Either by patching the patch itself or by applying another patch after a patch.

I add pathces for both possibilities: The first is a patch for the patch.

[Comment 7 Martin Väth 2011-01-19 20:51:28 UTC]

Created attachment 260293 [details, diff]
Patch to be applied after the ez-ipupdate-linux.patch

The other one is meant to be applied after the original patch.

(Of course, the two attachments exclude each other: only one should be applied).

[Comment 8 Boney McCracker 2011-01-20 12:29:28 UTC]

It builds fine on 2.6.37.

[Comment 9 Boney McCracker 2011-01-20 12:31:36 UTC]

Correction (wrong box).  It builds fine against 2.6.36-hardened-r6

[Comment 10 Diego Elio Pettenò (RETIRED) 2011-01-20 13:51:42 UTC]

That's kernel sources, we're talking about kernel headers.

I'll checkout Martin patch today and see if we can ave this, but it needs a new maintainer or a proxy maintainer... Martin, up to the task?

[Comment 11 Martin Väth 2011-01-20 17:10:46 UTC]

(In reply to comment #10)
> Martin, up to the task?

Since my future is (again) rather unclear in the moment, I cannot promise
anything these days. Also, I have no idea how to contact ez-ipupdate's upstream
(otherwise, I would have submitted my patch of bug 318905 to upstream...).

[Comment 12 Stefan Briesenick (RETIRED) 2011-01-23 12:14:11 UTC]

Debian patches are working. But since we also have some patches, I try to merge them somehow. Stay tuned...

[Comment 13 Martin Väth 2011-01-23 14:39:00 UTC]

(In reply to comment #12)
> Debian patches are working.

Of course, because it is my patch of bug 318905 which introduced the
#include <linux/if.h>
(which now collides with the #include <net/if.h>), and this patch is
probably not in Debian.

So a "solution" would be to throw out my patch from bug 318905.
But this would open again the problem which my patch should fix
(roughly speaking, that ez-ipupdate is able to read the IP adress
set by recent versions of dhcpcd under linux which was not the case
for the orignal ez-ipupdate, since dhcpcd uses the iprout2 interface
instead of the standard POSIX interface to set this address).

So perhaps a better solution would be to fix my patch (which I suggested
above): Avoid the #include <net/if.h> under linux (because we have there
#include <linux/if.h>).
Perhaps this was a bug in my patch from the very beginning, or this is a bug
of linux-headers, I do not know.

[Comment 14 Stefan Briesenick (RETIRED) 2011-01-23 20:24:09 UTC]

just removing <linux/if.h> was enough, since <net/if.h> were already included a few lines above.

fix commited to CVS.